Opened 3 years ago

Closed 2 years ago

#19550 closed Cleanup/optimization (fixed)

Make the filtered select widget wider

Reported by: aaugustin Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When editing users or groups permissions, often, the select widget crops the permission description. As shown on the screenshot attached to this ticket, cropping happens even for a model shipped by Django, namely ContentType. This isn't a very long name — 11 characters only.

The situation gets worse quickly when you have a long model name (eg. ScheduledMaintenance) and many custom permissions; it becomes very hard to differentiate them.

I think the widget was designed for 640px-wide screens. Nowadays I think we can aim for a minimum of 1024px. I'm attaching a patch.

Attachments (2)

Capture d’écran 2013-01-02 à 16.25.37.png (46.8 KB) - added by aaugustin 3 years ago.
19550.patch (758 bytes) - added by aaugustin 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by aaugustin

Changed 3 years ago by aaugustin

comment:1 Changed 3 years ago by claudep

  • Has patch set
  • Triage Stage changed from Unreviewed to Accepted

What about using percentages instead of pixels?

comment:2 Changed 3 years ago by aaugustin

I chose the least invasive patch in order to minimize the risk of breaking the widget's layout — under the "if it ain't broken don't fix it" doctrine.

comment:3 Changed 3 years ago by julien

  • Triage Stage changed from Accepted to Ready for checkin

comment:4 Changed 2 years ago by Aymeric Augustin <aymeric.augustin@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 0df8ff3dbec8e3ce1b699ee23e36fc211e44a612:

Fixed #19550 -- Made the filtered select widget wider in the admin.

Thanks Claude and Julien for the review.

Note: See TracTickets for help on using tickets.
Back to Top