Opened 11 years ago

Closed 11 years ago

#19543 closed Bug (fixed)

SimpleLazyObject missing __repr__ proxy

Reported by: spinus Owned by: fhahn
Component: Core (Other) Version: dev
Severity: Normal Keywords: SimpleLazyObject
Cc: flo@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no


SimpleLazyObject (from django.utils.functionals) does not proxy _repr_ method.
Use Case:

User.__unicode__ -> print data for user, example: ""
User.__repr__ -> print debugging data, example: "<User pk:1,, points:123>"

_unicode_ is used by most of application to render user content so I cant override it to using at logging. _repr_ is used in logging.

Example user message: "Hi %s"%request.user
Example logging message: "%r just logged in"%request.user

When user is wrapped with SimpleLazyObject _repr_ method of User is not called.
My idea is to make it available like

SimpleLazyObject._repr_ = lambda self: '<SimpleLazyObject: %r>'%self._wrapped


--- a/django/utils/
+++ b/django/utils/
@@ -303,6 +303,9 @@ class SimpleLazyObject(LazyObject):
     def __reduce__(self):
         return (self.__newobj__, (self.__class__,), self.__getstate__())
+    def __repr__(self):
+        return '<SimpleLazyObject: %r>' % self._wrapped
     # Need to pretend to be the wrapped class, for the sake of objects that care
     # about this (especially in equality tests)
     __class__ = property(new_method_proxy(operator.attrgetter("__class__")))

Attachments (1)

implemented_repr.diff (2.0 KB ) - added by fhahn 11 years ago.
implemented repr and updated test

Download all attachments as: .zip

Change History (7)

comment:1 by Preston Holmes, 11 years ago

Component: UncategorizedCore (Other)
Easy pickings: set
Needs tests: set
Patch needs improvement: set
Triage Stage: UnreviewedAccepted
Version: 1.5-beta-1master

Since a lazy object represents itself as the target class - it should try to be that class as much as possible, and not try to be "something special" even though it is.

So __repr__ should just proxy like other magic methods on the class.

Accepting the ticket based on the fact that we should do something explicit for __repr__, but rejecting the wrapped result.

Last edited 11 years ago by Preston Holmes (previous) (diff)

comment:2 by Preston Holmes, 11 years ago

After some further discussion about the value in debugging the following is now suggested:

Do show in __repr__ that we are a lazy object

check whether the lazy object has been evaluated

if not evaluated, include the repr of the setup function as the wrapped content - so that lazy objects are not evaluated at the time of repr call

otherwise wrap the target instances __repr__ method as proposed.

by fhahn, 11 years ago

Attachment: implemented_repr.diff added

implemented repr and updated test

comment:3 by fhahn, 11 years ago

Cc: flo@… added
Needs tests: unset
Owner: changed from nobody to fhahn
Patch needs improvement: unset
Status: newassigned

comment:4 by Tomek Paczkowski, 11 years ago

Triage Stage: AcceptedReady for checkin

Looks good!

comment:5 by fhahn, 11 years ago

forgot to link the github pull request:

comment:6 by Preston Holmes <preston@…>, 11 years ago

Resolution: fixed
Status: assignedclosed

In 0ea5bf88dddd7fbdef7fe8d00162c9753565f5c0:

Fixed #19543 -- implemented SimpleLazyObject.repr

Thanks to Florian Hahn for the patch

Note: See TracTickets for help on using tickets.
Back to Top