Opened 7 years ago

Closed 4 years ago

#19323 closed New feature (wontfix)

Add django.contrib.redirects setting for turning redirect on/off.

Reported by: Lebedev Ilya Owned by: Lebedev Ilya
Component: contrib.redirects Version: master
Severity: Normal Keywords: schemamigration, redirects, is_active
Cc: Lebedev Ilya, berker.peksag@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


At the moment django.contrib.redirects doesn't allow to disable particular redirect.
To do this I have do remove it completely or rename old_path to nonexistent. It neither clear nor correct.
Good solution is to add is_active bool field with default=True.

Change History (8)

comment:1 Changed 7 years ago by Russell Keith-Magee

Triage Stage: UnreviewedSomeday/Maybe
Type: UncategorizedNew feature

A reasonable idea, but we're hampered by the lack of a built in schema migration system.

Marking it someday/maybe; once we have a built-in migration system, this sort of change will be easy to make, but in the meantime, it's a non-trivial change.

comment:2 Changed 6 years ago by ZeevG

Can I assume this feature can be added now that we do have a built-in migration system?

I'm happy to write a patch, it seems like it might be a good ticket for me to get started with.

comment:3 Changed 6 years ago by ZeevG

Keywords: schemamigration added

comment:4 Changed 6 years ago by Tim Graham

Easy pickings: unset
Version: 1.4master

@ZeevG, migrations is still under active development and I don't think we're quite ready to add them to contrib apps yet. Stay tuned.

comment:5 Changed 5 years ago by Aymeric Augustin

The current plan is to make changes to models in contrib apps in Django 1.8.

comment:6 Changed 4 years ago by Tim Graham

Triage Stage: Someday/MaybeAccepted

We'd need to include a documentation warning that since the default RedirectFallbackMiddleware.response_redirect_class is HttpResponsePermanentRedirect, the flag may have no effect on users who have already accessed the redirect and have it cached by their browser.

comment:7 Changed 4 years ago by Berker Peksag

Cc: berker.peksag@… added

comment:8 Changed 4 years ago by Tim Graham

Resolution: wontfix
Status: newclosed

Discussion on the pull request with Berker concluded that adding this feature would likely be too confusing due to the default redirect being "permanent".

Note: See TracTickets for help on using tickets.
Back to Top