Opened 12 years ago
Closed 9 years ago
#19323 closed New feature (wontfix)
Add django.contrib.redirects setting for turning redirect on/off.
Reported by: | Lebedev Ilya | Owned by: | Lebedev Ilya |
---|---|---|---|
Component: | contrib.redirects | Version: | dev |
Severity: | Normal | Keywords: | schemamigration, redirects, is_active |
Cc: | Lebedev Ilya, berker.peksag@… | Triage Stage: | Accepted |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
At the moment django.contrib.redirects doesn't allow to disable particular redirect.
To do this I have do remove it completely or rename old_path to nonexistent. It neither clear nor correct.
Good solution is to add is_active bool field with default=True.
Change History (8)
comment:1 by , 12 years ago
Triage Stage: | Unreviewed → Someday/Maybe |
---|---|
Type: | Uncategorized → New feature |
comment:2 by , 11 years ago
Can I assume this feature can be added now that we do have a built-in migration system?
I'm happy to write a patch, it seems like it might be a good ticket for me to get started with.
comment:3 by , 11 years ago
Keywords: | schemamigration added |
---|
comment:4 by , 11 years ago
Easy pickings: | unset |
---|---|
Version: | 1.4 → master |
@ZeevG, migrations is still under active development and I don't think we're quite ready to add them to contrib apps yet. Stay tuned.
comment:5 by , 10 years ago
The current plan is to make changes to models in contrib apps in Django 1.8.
comment:6 by , 10 years ago
Triage Stage: | Someday/Maybe → Accepted |
---|
We'd need to include a documentation warning that since the default RedirectFallbackMiddleware.response_redirect_class
is HttpResponsePermanentRedirect
, the flag may have no effect on users who have already accessed the redirect and have it cached by their browser.
comment:8 by , 9 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Discussion on the pull request with Berker concluded that adding this feature would likely be too confusing due to the default redirect being "permanent".
A reasonable idea, but we're hampered by the lack of a built in schema migration system.
Marking it someday/maybe; once we have a built-in migration system, this sort of change will be easy to make, but in the meantime, it's a non-trivial change.