Opened 4 years ago

Closed 4 years ago

#19297 closed Cleanup/optimization (wontfix)

refactor settings setup code

Reported by: Preston Holmes Owned by: nobody
Component: Core (Other) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There is an increasing amount of code duplication in conf.init.LazySettings between _setup and configure

There are some differences in the way the actual settings holder is setup - but there should be a way to refactor this so that _setup calls configure, and put the common code there.

Change History (1)

comment:1 Changed 4 years ago by Preston Holmes

Resolution: wontfix
Status: newclosed

So after poking around this area I've concluded two things:

1) the savings gained aren't worth the gymnastics of a refactor here
2) configure really is doing a different enough thing to stay different

Note: See TracTickets for help on using tickets.
Back to Top