Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#19283 closed Bug (fixed)

Django CBV examples have broken import.

Reported by: Daniel Greenfeld Owned by: Daniel Greenfeld
Component: Documentation Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Aymeric Augustin)

In several places it is from django import models.

It is supposed to be from django.db import models.

Change History (8)

comment:1 Changed 4 years ago by Daniel Greenfeld

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Summary: Django CBV editing examples have broken import.Django CBV examples have broken import.

comment:2 Changed 4 years ago by Semion Sidorenko

I cannot find the problem you are describing, can you post a link or a path where it can be found ?

comment:3 Changed 4 years ago by Preston Holmes

Triage Stage: UnreviewedAccepted
Type: UncategorizedBug
Version: 1.4master

For sure they're there

element:docs (master)$ ack -a 'from django import models'
./ref/class-based-views/generic-editing.txt
19:        from django import models

./topics/class-based-views/generic-editing.txt
93:    from django import models
163:    from django import models
element:docs (master)$ 

comment:4 Changed 4 years ago by Semion Sidorenko

Oh ok, i was grepping for "djangoimport" actually. Can the description of the bug be updated ?

comment:5 in reply to:  4 Changed 4 years ago by Daniel Greenfeld

Replying to ssidorenko:

Oh ok, i was grepping for "djangoimport" actually. Can the description of the bug be updated ?

I lack the ability to edit the ticket now that it's been accepted. Perhaps a core developer has those rights?

comment:6 Changed 4 years ago by Aymeric Augustin

Description: modified (diff)

comment:7 Changed 4 years ago by Aymeric Augustin <aymeric.augustin@…>

Resolution: fixed
Status: newclosed

In 00ff69a827b38054afe557fc7d0a589b270ed871:

Fixed #19283 -- Fixed typo in imports in CBV docs.

comment:8 Changed 4 years ago by Aymeric Augustin <aymeric.augustin@…>

In 5e9af1600d74cbbfef5ad13fdf377dad73e0dd86:

[1.5.x] Fixed #19283 -- Fixed typo in imports in CBV docs.

Backport of 00ff69a from master.

Note: See TracTickets for help on using tickets.
Back to Top