Opened 12 years ago

Closed 11 years ago

Last modified 10 years ago

#19252 closed Bug (fixed)

Install from wheel package

Reported by: Alex Morega <alex@…> Owned by: nobody
Component: Packaging Version: dev
Severity: Release blocker Keywords:
Cc: Florian Apolloner Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


On Mac OS, pip wheel builds a Django wheel which installs cleanly. On Linux, it builds a wheel which (correctly) marks data files as such, and they get installed outside the django package. This doesn't happen on Mac OS since tricks distutils into handling data files as purelib files.

This little patch extends the hack to kick in when building wheels regardless of platform: The osx_install_data should probably be renamed though.

Change History (15)

comment:1 by Jacob, 12 years ago

Severity: NormalRelease blocker

comment:2 by anonymous, 12 years ago

Perhaps those files should always be purelib files?

comment:3 by Claude Paroz, 12 years ago

Triage Stage: UnreviewedAccepted
Version: 1.4master

comment:4 by Jannis Leidel, 12 years ago

Resolution: invalid
Status: newclosed

The wheel format isn't accepted yet ( and there is currently no such feature in pip. Closing as invalid as it's basically not a problem we should try to fix.

comment:5 by anonymous, 12 years ago

This bug is exactly the same thing that happens, and is currently compensated for, when building bdist_wininst installers. This should be a hint that data files are a problem.

Why not fix it for everyone by disusing the data files feature of distutils, regardless of sys.argv?

comment:6 by Carl Meyer, 11 years ago

Resolution: invalid
Severity: Release blockerNormal
Status: closednew

The wheel PEP is now accepted, and pip will soon have support AFAIK.

Regardless, comment 5 is correct that we jump through way too many hoops in our in order to try to trick distutils into handling data_files as if they were package_data, and that is the root cause of this bug. Instead we should just use package_data and solve the problem properly.

I don't believe this is a 1.5 release blocker, though, so re-setting the severity to Normal.

comment:7 by Jacob, 11 years ago

Severity: NormalRelease blocker

I'd like to start distributing Django as a wheel for 1.6, so I'm re-marking this as a release blocker. As we get closer to 1.6 we can revisit whether the ecosystem is "ready" and perhaps punt, but making this a blocker now means we won't just forget.

comment:8 by Aymeric Augustin, 11 years ago

Component: Core (Other)Packaging

comment:9 by Florian Apolloner, 11 years ago

FWIW our resolution of data-files is borked currently:

This results in: django/conf/project_template beeing data and django/conf/project_template/project_name beeing a package. As such a wheel install currently puts somehwere else and startproject doesn't collect all files…

So the whole needs a bit more rework.

comment:10 by Florian Apolloner, 11 years ago

Cc: Florian Apolloner added

comment:11 by Florian Apolloner, 11 years ago

Last edited 11 years ago by Florian Apolloner (previous) (diff)

comment:12 by Florian Apolloner, 11 years ago

Building wheels is possible via:

pip wheel .

(Assuming pip 1.4 and installed distribute and wheel). python bdist_wheel doesn't work since we don't use setuptools in, but that's fine.

Last edited 11 years ago by Florian Apolloner (previous) (diff)

comment:13 by Jannis Leidel <jannis@…>, 11 years ago

Resolution: fixed
Status: newclosed

In a5becad9094e5c5403b692b9a7b3a6ffaabf64a3:

Fixed #19252 -- Added support for wheel packages.

Signed-off-by: Jannis Leidel <jannis@…>

comment:14 by Jannis Leidel <jannis@…>, 11 years ago

In 4391718f26466f82f943e37368181d5c0520fa35:

[1.5.x] Fixed #19252 -- Added support for wheel packages.

Backport from master (a5becad9094e5c5403b692b9a7b3a6ffaabf64a3).

Signed-off-by: Jannis Leidel <jannis@…>

Note: See TracTickets for help on using tickets.
Back to Top