Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19243 closed Cleanup/optimization (fixed)

Edit GeoDjango Tutorial for consistency and style.

Reported by: shepdl Owned by: Tim Graham <timograham@…>
Component: Documentation Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There are a few grammatical problems with consistency and style in the GeoDjango Tutorial. Nothing factually wrong, but some changes would make it easier to read, I think. Also, there is at least one empty section ("Google.")

Change History (12)

comment:1 Changed 2 years ago by shepdl

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to shepdl
  • Patch needs improvement unset

comment:2 Changed 2 years ago by claudep

We welcome any improvements to the docs, but please then provide a patch with your suggestions. It is worth nothing having open tickets with too general statements like this. Do you plan to provide a patch soon?

comment:3 Changed 2 years ago by claudep

  • Resolution set to needsinfo
  • Status changed from new to closed

Once again, we'd really appreciate any patch aimed to improve GeoDjango docs. I'm just setting this ticket as needinfo because the current description is too vague in its current state.

comment:4 Changed 2 years ago by shepdl

My apologies. I added this as part of something I was working on at a hackathon, had a bunch of trouble with Git (my own fault) so I couldn't commit the patch, and then went out of town for a week. I'll provide this soon.

comment:5 Changed 2 years ago by anonymous

  • Resolution needsinfo deleted
  • Status changed from closed to reopened

comment:6 Changed 2 years ago by shepdl

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:7 Changed 2 years ago by timo

  • Has patch set
  • Resolution fixed deleted
  • Status changed from closed to reopened

Thanks for this, however, don't close a ticket until a core developer commits it. You can put a link to your pull request in the ticket and check the "Has Patch" box so people can find it for review.

https://github.com/django/django/pull/531

comment:8 Changed 2 years ago by claudep

  • Owner shepdl deleted
  • Status changed from reopened to new
  • Triage Stage changed from Unreviewed to Accepted

comment:9 Changed 2 years ago by claudep

Thanks, this looks very good (as seen by a non-native speaker). I'd still like a quick review by a native English speaker before the commit, if possible.

comment:10 Changed 2 years ago by timo

Left a few trivial comments, English looks fine to me.

comment:11 Changed 2 years ago by Tim Graham <timograham@…>

  • Owner set to Tim Graham <timograham@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 8e5573e99abd5351dfbd6de1214662ecf7f6c9ba:

Fixed #19243 - Edited GeoDjango Tutorial for consistency and style.

comment:12 Changed 2 years ago by Tim Graham <timograham@…>

In 187441602c992fe8e97e32a7a53cc433cf06dd46:

[1.5.X] Fixed #19243 - Edited GeoDjango Tutorial for consistency and style.

Backport of 8e5573e99a from master

Note: See TracTickets for help on using tickets.
Back to Top