Opened 4 years ago

Closed 4 years ago

#19188 closed Cleanup/optimization (fixed)

Add 'page_kwarg' attribute to `MultipleObjectMixin`, removing hardcoded "page"

Reported by: Tom Christie Owned by: nobody
Component: Generic views Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

At the moment it's awkward to modify the generic views to use a custom name for the 'page' query parameter.
This fix brings the behavior more in line with other generic view properties.

Use cases:

  • Sites in a non-english language may want the query parameter to read as eg. 'pagina=4', not 'page=4'
  • Users with specific pagination requirements may need to change the query parameter name (eg perhaps for compatibility with a specific javascript paging library)

Pull req: https://github.com/django/django/pull/467 (Includes docs & test)

Change History (2)

comment:1 Changed 4 years ago by Marc Tamlyn

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedReady for checkin

comment:2 Changed 4 years ago by Aymeric Augustin

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.
Back to Top