Opened 4 years ago
Closed 4 years ago
#19157 closed Bug (fixed)
String is marked for translation in one file, but not in other.
| Reported by: | Alexey Boriskin | Owned by: | Claude Paroz |
|---|---|---|---|
| Component: | contrib.admindocs | Version: | master |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
String 'A custom field type' is marked for translation in the file django/admindocs/tests/__init__.py, but it is not marked in the file django/admindocs/tests/fields.py
Either both string should be marked for i18n, or none of them.
I've discovered it accidentially, when seeing new text for translation for 1.5.
This will probably cause tests to fail after the moment when translation will be pulled from transifex.
Change History (3)
comment:1 Changed 4 years ago by
| Needs documentation: | unset |
|---|---|
| Needs tests: | unset |
| Patch needs improvement: | unset |
| Triage Stage: | Unreviewed → Accepted |
comment:2 Changed 4 years ago by
| Owner: | changed from nobody to Claude Paroz |
|---|---|
| Status: | new → assigned |
Sorry, I introduced the regression in [eba4197c71d152b]. As this string is only used in tests, I don't see any point in giving more work for translators.
comment:3 Changed 4 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
I suggest both be marked for translation. Why do you expect tests would fail?