Opened 2 years ago

Closed 2 years ago

#19157 closed Bug (fixed)

String is marked for translation in one file, but not in other.

Reported by: void Owned by: claudep
Component: contrib.admindocs Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

String 'A custom field type' is marked for translation in the file django/admindocs/tests/__init__.py, but it is not marked in the file django/admindocs/tests/fields.py
Either both string should be marked for i18n, or none of them.
I've discovered it accidentially, when seeing new text for translation for 1.5.

This will probably cause tests to fail after the moment when translation will be pulled from transifex.

Change History (3)

comment:1 Changed 2 years ago by julien

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

I suggest both be marked for translation. Why do you expect tests would fail?

comment:2 Changed 2 years ago by claudep

  • Owner changed from nobody to claudep
  • Status changed from new to assigned

Sorry, I introduced the regression in [eba4197c71d152b]. As this string is only used in tests, I don't see any point in giving more work for translators.

comment:3 Changed 2 years ago by Claude Paroz <claude@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58cc3e8484c4fb7db787ec2c21d8aeac3d131f3e:

Fixed #19157 -- Removed test-only string from translatable strings

Thanks Alexey Boriskin for the report. Refs #18240.

Note: See TracTickets for help on using tickets.
Back to Top