#19152 closed Cleanup/optimization (fixed)
Add support to create database without template_postgis with PostGIS 2
| Reported by: | Claude Paroz | Owned by: | nobody |
|---|---|---|---|
| Component: | GIS | Version: | 1.4 |
| Severity: | Release blocker | Keywords: | |
| Cc: | ckarrie@…, flavio.curella@…, aurelio@… | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
After support for PostGIS 2 has been added (ticket #16455), we should now support the new method of creating PostGIS databases without template, through the "CREATE EXTENSION postgis" command (as described in current documentation, https://docs.djangoproject.com/en/dev/ref/contrib/gis/install/#post-installation).
Change History (10)
comment:1 by , 12 years ago
| Cc: | added |
|---|
comment:2 by , 12 years ago
comment:3 by , 12 years ago
| Cc: | added |
|---|
comment:4 by , 12 years ago
| Has patch: | set |
|---|
Thanks Flavio, now I think that the patch is in a state ready for a review by Justin.
comment:5 by , 12 years ago
| Cc: | added |
|---|
comment:6 by , 12 years ago
| Patch needs improvement: | set |
|---|
I just reviewed the pull request; I'd like to see one improvement and one explanation.
comment:7 by , 12 years ago
Hi @aaugustin,
Thanks for reviewing the PR.
I've updated the pull request with the improvements you suggested.
I'm not 100% sure that the changes to _create_test_db are what you wanted. Let me know if you have any suggestions.
comment:8 by , 12 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Tested with postgis 1.5/2.0 with template and with 2.0 without template.
comment:9 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Flavio Currella proposed a pull request: https://github.com/django/django/pull/439