Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#19152 closed Cleanup/optimization (fixed)

Add support to create database without template_postgis with PostGIS 2

Reported by: claudep Owned by: nobody
Component: GIS Version: 1.4
Severity: Release blocker Keywords:
Cc: ckarrie@…, flavio.curella@…, aurelio@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

After support for PostGIS 2 has been added (ticket #16455), we should now support the new method of creating PostGIS databases without template, through the "CREATE EXTENSION postgis" command (as described in current documentation, https://docs.djangoproject.com/en/dev/ref/contrib/gis/install/#post-installation).

Change History (10)

comment:1 Changed 3 years ago by ckarrie

  • Cc ckarrie@… added

comment:2 Changed 3 years ago by claudep

Flavio Currella proposed a pull request: https://github.com/django/django/pull/439

comment:3 Changed 3 years ago by fcurella

  • Cc flavio.curella@… added

comment:4 Changed 3 years ago by claudep

  • Has patch set

Thanks Flavio, now I think that the patch is in a state ready for a review by Justin.

comment:5 Changed 3 years ago by tinio

  • Cc aurelio@… added

comment:6 Changed 3 years ago by aaugustin

  • Patch needs improvement set

I just reviewed the pull request; I'd like to see one improvement and one explanation.

comment:7 Changed 3 years ago by fcurella

Hi @aaugustin,

Thanks for reviewing the PR.

I've updated the pull request with the improvements you suggested.

I'm not 100% sure that the changes to _create_test_db are what you wanted. Let me know if you have any suggestions.

comment:8 Changed 3 years ago by claudep

  • Triage Stage changed from Accepted to Ready for checkin

Tested with postgis 1.5/2.0 with template and with 2.0 without template.

comment:9 Changed 3 years ago by Claude Paroz <claude@…>

  • Resolution set to fixed
  • Status changed from new to closed

In fbd1df8e16fc17a5d73f36136298c20b8ec3d618:

Fixed #19152 -- Allowed PostGIS tests to be run without template

From version 2, a PostGIS template is no longer required to create
a GIS-enabled database.

comment:10 Changed 3 years ago by Claude Paroz <claude@…>

In d46b24e682cdae4404c42477956adc3e778a573a:

[1.5.x] Fixed #19152 -- Allowed PostGIS tests to be run without template

From version 2, a PostGIS template is no longer required to create
a GIS-enabled database.
Backport of fbd1df8e from master.

Note: See TracTickets for help on using tickets.
Back to Top