Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#19142 closed Bug (fixed)

accept_language_re rejects languages which include numeric UN region codes

Reported by: DrMeers Owned by: Architekt
Component: Internationalization Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

e.g. "es-419"

See discussion on https://github.com/django/django/pull/87

Change History (10)

comment:1 Changed 3 years ago by claudep

  • Easy pickings set
  • Has patch set
  • Needs documentation unset
  • Needs tests set
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 3 years ago by Architekt

  • Owner changed from nobody to Architekt

comment:3 Changed 3 years ago by Architekt

  • Triage Stage changed from Accepted to Ready for checkin

comment:4 Changed 3 years ago by Architekt

  • Needs tests unset

comment:5 Changed 3 years ago by Architekt

  • Triage Stage changed from Ready for checkin to Accepted

comment:6 Changed 3 years ago by Jan Bednařík <jan.bednarik@…>

  • Resolution set to fixed
  • Status changed from new to closed

In e6b34193c5c7d117ededdab04bb16caf8864f07c:

Fixed #19142 -- Language codes can include numbers (RFC 3066).

comment:7 Changed 3 years ago by Claude Paroz <claude@…>

In 22471a41ba676afdab55daf34f1c7c25b327bbb9:

Merge pull request #457 from JanBednarik/ticket_19142

Fixed #19142 -- Language codes can include numbers (RFC 3066)

comment:8 Changed 2 years ago by esevece

The package downloaded by PIP has not the fix. I tried upgrading but is the same package.
Is possible update that? Because I'm using Heroku, so I can't modify the code of Django, I only can use pip.

comment:9 Changed 2 years ago by charettes

The fix is available in the 1.5.X which you can install by issuing a pip install https://github.com/django/django/tree/stable/1.5.x.tar.gz until the final version is released.

comment:10 Changed 2 years ago by esevece

Thank you charettes!
I didn't know that I could install a tar.gz directly from pip.

Note: See TracTickets for help on using tickets.
Back to Top