Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#19142 closed Bug (fixed)

accept_language_re rejects languages which include numeric UN region codes

Reported by: Simon Meers Owned by: Jan Bednařík
Component: Internationalization Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

e.g. "es-419"

See discussion on https://github.com/django/django/pull/87

Change History (10)

comment:1 by Claude Paroz, 11 years ago

Easy pickings: set
Has patch: set
Needs tests: set
Triage Stage: UnreviewedAccepted

comment:2 by Jan Bednařík, 11 years ago

Owner: changed from nobody to Jan Bednařík

comment:3 by Jan Bednařík, 11 years ago

Triage Stage: AcceptedReady for checkin

comment:4 by Jan Bednařík, 11 years ago

Needs tests: unset

comment:5 by Jan Bednařík, 11 years ago

Triage Stage: Ready for checkinAccepted

comment:6 by Jan Bednařík <jan.bednarik@…>, 11 years ago

Resolution: fixed
Status: newclosed

In e6b34193c5c7d117ededdab04bb16caf8864f07c:

Fixed #19142 -- Language codes can include numbers (RFC 3066).

comment:7 by Claude Paroz <claude@…>, 11 years ago

In 22471a41ba676afdab55daf34f1c7c25b327bbb9:

Merge pull request #457 from JanBednarik/ticket_19142

Fixed #19142 -- Language codes can include numbers (RFC 3066)

comment:8 by Stefano Vettorazzi Campos, 11 years ago

The package downloaded by PIP has not the fix. I tried upgrading but is the same package.
Is possible update that? Because I'm using Heroku, so I can't modify the code of Django, I only can use pip.

comment:9 by Simon Charette, 11 years ago

The fix is available in the 1.5.X which you can install by issuing a pip install https://github.com/django/django/tree/stable/1.5.x.tar.gz until the final version is released.

comment:10 by Stefano Vettorazzi Campos, 11 years ago

Thank you charettes!
I didn't know that I could install a tar.gz directly from pip.

Note: See TracTickets for help on using tickets.
Back to Top