Opened 13 years ago

Closed 13 years ago

#19094 closed Bug (fixed)

FakePayload should accept unicode

Reported by: Ondrej Slinták Owned by: nobody
Component: Testing framework Version: dev
Severity: Normal Keywords:
Cc: Claude Paroz Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As discussed ​on GitHub, I think ​FakePayload should accept unicode. Current implementation breaks stuff that worked in 1.4. @claudep had some ideas, so I'm creating this ticket for his patch.

Attachments (1)

19094-1.diff​ (6.3 KB ) - added by Claude Paroz 13 years ago.
Improved FakePayload to support write, len and string input

Download all attachments as: .zip

Change History (4)

comment:1 by Ondrej Slinták, 13 years ago

Type: New feature → Bug

by Claude Paroz, 13 years ago

Attachment: 19094-1.diff​ added

Improved FakePayload to support write, len and string input

comment:2 by Claude Paroz, 13 years ago

Has patch: set
Triage Stage: Unreviewed → Accepted

Note that the modified tests in my patch are not necessary, they still pass with the modified FakePayload. However I modified them to show the advantage of the enhanced FakePayload.

comment:3 by Claude Paroz, 13 years ago

Resolution: → fixed
Status: new → closed

In dcbf08cce59ceb83918b1b63c2bb827828bbdd2c:

Fixed #19094 -- Improved FakePayload to support write, len and string input

Thanks Ondrej Slinták for the suggestion.

Note: See TracTickets for help on using tickets.
Back to Top