Code

#19094 closed Bug (fixed)

FakePayload should accept unicode

Reported by: ondrowan Owned by: nobody
Component: Testing framework Version: master
Severity: Normal Keywords:
Cc: claudep Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As discussed on GitHub, I think FakePayload should accept unicode. Current implementation breaks stuff that worked in 1.4. @claudep had some ideas, so I'm creating this ticket for his patch.

Attachments (1)

19094-1.diff (6.3 KB) - added by claudep 21 months ago.
Improved FakePayload to support write, len and string input

Download all attachments as: .zip

Change History (4)

comment:1 Changed 21 months ago by ondrowan

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Type changed from New feature to Bug

Changed 21 months ago by claudep

Improved FakePayload to support write, len and string input

comment:2 Changed 21 months ago by claudep

  • Has patch set
  • Triage Stage changed from Unreviewed to Accepted

Note that the modified tests in my patch are not necessary, they still pass with the modified FakePayload. However I modified them to show the advantage of the enhanced FakePayload.

comment:3 Changed 21 months ago by claudep

  • Resolution set to fixed
  • Status changed from new to closed

In dcbf08cce59ceb83918b1b63c2bb827828bbdd2c:

Fixed #19094 -- Improved FakePayload to support write, len and string input

Thanks Ondrej Slinták for the suggestion.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.