Code

#18968 closed Bug (fixed)

Spatialite GML test failure

Reported by: bkg Owned by: bkg
Component: GIS Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The GML returned from Spatialite has changed format in version 3.0 and above. When testing with Spatialite 3.0 and 3.1, the regex in test_gml no longer returns a match.

======================================================================
FAIL: test_gml (django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest)
Testing GML output from the database using GeoQuerySet.gml().
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/brian/.virtualenvs/django/django.git/django/contrib/gis/tests/geoapp/tests.py", line 530, in test_gml
    self.assertTrue(gml_regex.match(ptown.gml))
AssertionError: None is not true

----------------------------------------------------------------------
Ran 234 tests in 6.342s

FAILED (failures=1)

Attachments (0)

Change History (5)

comment:1 Changed 22 months ago by bkg

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 22 months ago by bkg

A simple fix is available here:

https://github.com/bkg/django/tree/ticket_18968

comment:3 Changed 22 months ago by bkg

  • Has patch set

comment:4 Changed 22 months ago by claudep

  • Triage Stage changed from Unreviewed to Ready for checkin

comment:5 Changed 22 months ago by Claude Paroz <claude@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 0ab8c58ca896643ea0bb0830a96274160d14cc69:

Fixed #18968 -- Only use separate GML regex for SpatiaLite < 3.0

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.