Opened 13 years ago

Closed 13 years ago

#18947 closed Bug (fixed)

Uploaded files have exec bit set by default

Reported by: Lauri Tirkkonen Owned by: nobody
Component: File uploads/storage Version: dev
Severity: Normal Keywords:
Cc: charette.s@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Pull request at ​https://github.com/django/django/pull/369

Change History (5)

comment:1 by Lauri Tirkkonen, 13 years ago

Component: Uncategorized → File uploads/storage

comment:2 by Simon Charette, 13 years ago

Cc: charette.s@… added
Triage Stage: Unreviewed → Ready for checkin
Version: 1.4 → master

comment:3 by Aymeric Augustin, 13 years ago

How does this relate to ​settings.FILE_UPLOAD_PERMISSIONS?

comment:4 by Florian Apolloner, 13 years ago

FILE_UPLOAD_PERMISSIONS still can override it, this change is just here to provide a more sensible default, see ​https://github.com/lotheac/django/blob/67f844ed7b21ae154a5575a389d366571226b9d4/django/core/files/storage.py#L221

comment:5 by Florian Apolloner <florian@…>, 13 years ago

Resolution: → fixed
Status: new → closed

In e8c6aff3bf31b775dd70581b1cf6f86d5abd4001:

Fixed #18947 -- Don't make uploaded files executeable by default.

Thanks to Lauri Tirkkonen for the patch.

Note: See TracTickets for help on using tickets.
Back to Top