Opened 3 years ago

Closed 3 years ago

#18947 closed Bug (fixed)

Uploaded files have exec bit set by default

Reported by: lotheac Owned by: nobody
Component: File uploads/storage Version: master
Severity: Normal Keywords:
Cc: charette.s@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Change History (5)

comment:1 Changed 3 years ago by lotheac

  • Component changed from Uncategorized to File uploads/storage
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 3 years ago by charettes

  • Cc charette.s@… added
  • Triage Stage changed from Unreviewed to Ready for checkin
  • Version changed from 1.4 to master

comment:3 Changed 3 years ago by aaugustin

How does this relate to settings.FILE_UPLOAD_PERMISSIONS?

comment:4 Changed 3 years ago by apollo13

FILE_UPLOAD_PERMISSIONS still can override it, this change is just here to provide a more sensible default, see https://github.com/lotheac/django/blob/67f844ed7b21ae154a5575a389d366571226b9d4/django/core/files/storage.py#L221

comment:5 Changed 3 years ago by Florian Apolloner <florian@…>

  • Resolution set to fixed
  • Status changed from new to closed

In e8c6aff3bf31b775dd70581b1cf6f86d5abd4001:

Fixed #18947 -- Don't make uploaded files executeable by default.

Thanks to Lauri Tirkkonen for the patch.

Note: See TracTickets for help on using tickets.
Back to Top