Code

Opened 19 months ago

Closed 9 months ago

Last modified 9 months ago

#18944 closed Cleanup/optimization (fixed)

1.3 Release Notes omit backwards incompatible addition of from_email argument to PasswordResetForm

Reported by: DrMeers Owned by: DrMeers
Component: Documentation Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

1.4 documents this: https://docs.djangoproject.com/en/dev/releases/1.4/#password-reset-view-now-accepts-subject-template-name

1.3 does not document this: https://github.com/django/django/commit/4084bc73

Recently came across this when performing a 1.2 -> 1.4 upgrade, having trawled both sets of release notes for things to watch out for.

Any reason I shouldn't add a caveat to the backwards incompatible changes section in the 1.3 release notes at this late stage?

Attachments (0)

Change History (5)

comment:1 in reply to: ↑ description Changed 19 months ago by claudep

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Replying to DrMeers:

Any reason I shouldn't add a caveat to the backwards incompatible changes section in the 1.3 release notes at this late stage?

No reason for me, the more docs, the better.

comment:2 Changed 9 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In dab921751d6410d9d1efcbad1819acea435dbd43:

Fixed #18944 -- Documented PasswordResetForm's from_email argument as a backwards incompatible change for 1.3

Thanks DrMeers for the report.

comment:3 Changed 9 months ago by Tim Graham <timograham@…>

In 7b7592cafaff9b7b06a4949465bb723541ede40a:

[1.4.x] Fixed #18944 -- Documented PasswordResetForm's from_email argument as a backwards incompatible change for 1.3

Thanks DrMeers for the report.

Backport of dab921751d from master

comment:4 Changed 9 months ago by Tim Graham <timograham@…>

In f03398a2461e240c7e7401e1c51878c8af619ed2:

[1.6.x] Fixed #18944 -- Documented PasswordResetForm's from_email argument as a backwards incompatible change for 1.3

Thanks DrMeers for the report.

Backport of dab921751d from master

comment:5 Changed 9 months ago by Tim Graham <timograham@…>

In 0a91a8dbe3e406d5a321bdcea0d1ab82110c157f:

[1.5.x] Fixed #18944 -- Documented PasswordResetForm's from_email argument as a backwards incompatible change for 1.3

Thanks DrMeers for the report.

Backport of dab921751d from master

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.