Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#18933 closed Cleanup/optimization (fixed)

docstring for cycle templatetag method differs from documentation

Reported by: Martey Dodoo Owned by: nobody
Component: Documentation Version: 1.4
Severity: Normal Keywords: cycle templatetag
Cc: marc.tamlyn@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

A code example in the docstring in the cycle method in django.template.defaulttags for the silent option of the cycle templatetag differs from the example in the actual documentation.

​Line 536 of defaulttags.py contains "{% cycle rowcolors %}" when it should be "{{ rowcolors }}". The documentation was changed in ​a commit fixing ticket #15570.

Change History (4)

comment:1 by Martey Dodoo <djangoproject.com@…>, 12 years ago

I have added a fix for this on ​a branch on Github and submitted a pull request.

comment:2 by Marc Tamlyn, 12 years ago

Cc: marc.tamlyn@… added
Has patch: set
Triage Stage: Unreviewed → Ready for checkin

comment:3 by Martey Dodoo <martey@…>, 12 years ago

Resolution: → fixed
Status: new → closed

In 3fb2662edcdfb03ebb4b2ab60ffe309104809246:

Fixes #18933. Fixes code example in docstring.

Makes code example of silent keyword docstring in cycle templatetag
method the same as in the documentation.

comment:4 by Tim Graham <timograham@…>, 12 years ago

In 87c06fa4f4b908b940bea7cde95251d4daf78f3c:

Merge pull request #364 from martey/ticket_18933

Fixed #18933 - Fixes code example for cycle in docstring.

Note: See TracTickets for help on using tickets.
Back to Top