Opened 10 years ago

Closed 9 years ago

#1888 closed defect (fixed)

Small interface inaccuracy when using filter_interface=models.VERTICAL

Reported by: wnielson Owned by: Ryan Kanno
Component: contrib.admin Version:
Severity: normal Keywords: sprintsept14
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

when using

models.ManyToManyField(filter_interface=models.VERTICAL)

the arrow icon next to

Select your choice(s) and click

points to the right and should point down. In addition,

'Choose all', 'Clear all'

options do not appear in this mode.

Attachments (1)

django_filter_interface.diff (1.2 KB) - added by Ryan Kanno 9 years ago.
more DRY as suggested by SmileyChris

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by Adrian Holovaty

Summary: 'Select your choice(s) and click' issuesSmall interface inaccuracy when using filter_interface=models.VERTICAL

comment:2 Changed 10 years ago by Chris Beaven

Triage Stage: UnreviewedAccepted

Albiet small, it sounds like a valid bug.

comment:3 Changed 9 years ago by Ryan Kanno

Has patch: set
Owner: changed from nobody to Ryan Kanno

Widgets.css has the following:

.stacked .selector-chooseall, .stacked .selector-clearall { display:none; }

so it's apparent chooseall and clearall were hidden for models.VERTICAL.
The attached patch corrects the other small issue.

comment:4 Changed 9 years ago by Ryan Kanno

Keywords: sprintsept14 added

Changed 9 years ago by Ryan Kanno

more DRY as suggested by SmileyChris

comment:5 Changed 9 years ago by Chris Beaven

Triage Stage: AcceptedReady for checkin

comment:6 Changed 9 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [6262]) Fixed #1888 -- Fixed small interface inaccuracy when using filter_interface=models.VERTICAL. Thanks, ryankanno, wnielson and SmileyChris

Note: See TracTickets for help on using tickets.
Back to Top