FilteredSelectMultiple loses data

[Simon Litchfield]

If page loading breaks at just the right time, it's possible we've seen that the currently selected options are not transferred from the underlying form's select element into the javascript-powered FilteredSelectMultiple widget.

Then, if the user goes ahead and presses save, the options are wiped/overridden.

A solution here would be to set a flag once the options are safely transferred to the widget, and only pass the widget's selections back into the form's select element during submit if the flag is set.

[Travis Swicegood]

Closing with "needsinfo". Can you provide the steps for a test case to reproduce this? Please re-open with that information if you can.

[Simon Litchfield]

To test, run up an admin page with plenty of heavy fields intertwined with a few FilteredSelectMultiple widgets that all have long lists of options. Then run it over a slow connection (ie not local).

Unfortunately it's impractical to post a test case with data here- maybe it'd be better to demo this bug via a URL.

[Russell Keith-Magee]

I can see how this could happen. The problem is caused because the widget that actually submits the data isn't related to the widget that displays the data, and if you have a partial page load, you could end up with a situation where *some* of the data has been updated into the display widget -- and when you hit submit, that partial information is submitted as new data. The suggestion from the reporter -- i.e., a safety catch that only engages when the page is fully loaded -- sounds like the right fix to me.

[Julien Phalip]

It looks like this was accidentally closed :)

[Simon Litchfield]

Russ- you got it mate. I'll spin up a fix.

[anonymous]

I am seeing a phenomenon that might be related to this:

An admin change_form with a FilteredSelectMultiple and some js code that triggers form submission by jQuery $("#form").submit will also lose all the data in FilteredSelectMultiple. It seems that the submit handler in SelectFilter2.js:92 is not executed when you are submitting the form from jQuery, no idea why.

[Glenn Wang]

Replying to anonymous:

I am seeing a phenomenon that might be related to this:

An admin change_form with a FilteredSelectMultiple and some js code that triggers form submission by jQuery $("#form").submit will also lose all the data in FilteredSelectMultiple. It seems that the submit handler in SelectFilter2.js:92 is not executed when you are submitting the form from jQuery, no idea why.

Yeah, I'd experienced this too, a standalone <button type='submit'>
works while $("#form").submit() won't. Any ideas why?

[Collin Anderson]

Is this related to #13614 ?