Opened 4 years ago

Closed 4 years ago

#18862 closed Cleanup/optimization (fixed)

FlatPages get_absolute_url should pay attention to script prefix

Reported by: Gunnar Scherf Owned by: nobody
Component: contrib.flatpages Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


When hosting a django app under a subpath of a domain, then get_absolute_url returns the url without the subpath.

    def get_absolute_url(self):
        return self.url

Better would be if the subpath is recognized

    def get_absolute_url(self):
        absolute_url = "%s%s" % (get_script_prefix().rstrip('/'), self.url)
        return absolute_url

Change History (4)

comment:1 Changed 4 years ago by Thejaswi Puthraya

Component: Uncategorizedcontrib.flatpages
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:2 Changed 4 years ago by Claude Paroz

Triage Stage: UnreviewedAccepted

comment:3 Changed 4 years ago by Aymeric Augustin

Yes, this is necessary because flatpages bypass the URL resolver (and specifically the reverse function) entirely.

comment:4 Changed 4 years ago by Aymeric Augustin <aymeric.augustin@…>

Resolution: fixed
Status: newclosed

In a44531ae1592cf266e6c24387f49d665c639b480:

Fixed #18862 -- Honored script prefix in FlatPage.get_absolute_url.

Note: See TracTickets for help on using tickets.
Back to Top