Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#18824 closed Bug (fixed)

Allow deletion of a setting from overridden settings

Reported by: Claude Paroz Owned by: nobody
Component: Testing framework Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Currently, if you call del settings.SOME_SETTING when the settings have been customized with override_settings, the setting still exists if it was pre-existing in the original settings object. See #17966 for a real use case.

Attachments (1)

18824-1.diff​ (1.9 KB ) - added by Claude Paroz 12 years ago.
UserSettingsHolder keeping track of deleted settings

Download all attachments as: .zip

Change History (6)

by Claude Paroz, 12 years ago

Attachment: 18824-1.diff​ added

UserSettingsHolder keeping track of deleted settings

comment:1 by Claude Paroz, 12 years ago

Has patch: set

comment:2 by Jannis Leidel, 12 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:3 by Claude Paroz <claude@…>, 12 years ago

Resolution: → fixed
Status: new → closed

In [22f85b9057825b5b4139abf5fd7e8c4ba0d16981]:

Fixed #18824 -- Allow deleting a setting from overriden settings

comment:4 by Claude Paroz <claude@…>, 11 years ago

In 3417ba03094b644f01597d6b5a43ccbc71a55378:

Also allowed a non-overridden setting to be deleted

Refs #20032, #18824. Thanks ztorstri at gmail.com for the report.

comment:5 by Claude Paroz <claude@…>, 11 years ago

In a6eda3a5fc524333b476deed5057ee9803d91108:

[1.7.x] Also allowed a non-overridden setting to be deleted

Refs #20032, #18824. Thanks ztorstri at gmail.com for the report.
Backport of 3417ba0309 from master.

Note: See TracTickets for help on using tickets.
Back to Top