Opened 12 years ago

Closed 12 years ago

#18775 closed Bug (invalid)

ROPhoneNumberField does not support several Romanian phone number formats

Reported by: Daniel Ursache-Dogariu Owned by: Daniel Ursache-Dogariu
Component: contrib.localflavor Version: dev
Severity: Normal Keywords: romanian, phone, field, localflavorsplit
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The ROPhoneNumberField form field only supports 10 digit phone numbers. It does not accept valid formats like the short national phone numbers (3 or 6 digits), or geographic short numbers (7 digits).

Change History (4)

comment:1 by Daniel Ursache-Dogariu, 12 years ago

Triage Stage: Unreviewed → Fixed on a branch

Added validation for

  • normal phone numbers: 0xxxxxxxxx
  • geographic short phone numbers: 0xxxxxx
  • national short phone numbers: 1xx, 1xxxxx

Tests pass under SQLite.

Last edited 12 years ago by Daniel Ursache-Dogariu (previous) (diff)

comment:2 by Aymeric Augustin, 12 years ago

Triage Stage: Fixed on a branch → Unreviewed

"Fixed on a branch" lost most of its meaning since the move to git, it was for official SVN branches.

comment:3 by Daniel Ursache-Dogariu, 12 years ago

Has patch: set

Git pull request:

​https://github.com/django/django/pull/275

comment:4 by Aymeric Augustin, 12 years ago

Keywords: localflavorsplit added
Resolution: → invalid
Status: new → closed

django.contrib.localflavor is now deprecated — see ​https://docs.djangoproject.com/en/dev/ref/contrib/localflavor/

A repository was created for each localflavor at ​https://github.com/django/django-localflavor-? (Replace with the country code.)

If you're still interested in this ticket, could you create a pull request on that repository?

Sorry for not resolving this issue earlier, and thanks for your input!

Note: See TracTickets for help on using tickets.
Back to Top