Opened 4 years ago

Closed 3 years ago

#18719 closed Cleanup/optimization (fixed)

django.utils.encoding.smart_unicode/smart_str handle strings_only inconsistently

Reported by: Aymeric Augustin Owned by: Aymeric Augustin
Component: Utilities Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

smart_unicode calls is_protected_type, smart_str just checks for None and int.

It seems to me that smart_str should rely on is_protected_type too, for consistency.

If there's a reason for implementing a different check, it should be at least explained in a comment.

Change History (4)

comment:1 Changed 4 years ago by Claude Paroz

Triage Stage: UnreviewedAccepted

+1 to use is_protected_type in force_bytes

comment:2 Changed 4 years ago by Aymeric Augustin

Component: Core (Other)Utilities

comment:3 Changed 4 years ago by Aymeric Augustin

Owner: changed from nobody to Aymeric Augustin
Status: newassigned

comment:4 Changed 3 years ago by Aymeric Augustin <aymeric.augustin@…>

Resolution: fixed
Status: assignedclosed

In e492ab8e7eb5fc2c1d4a50669aeaa3d6163dc5f3:

Fixed #18719 -- Made force_bytes more consistent with force_text.

Note: See TracTickets for help on using tickets.
Back to Top