Opened 12 years ago
Closed 8 years ago
#18717 closed Bug (needsinfo)
Setting attributes on deferred objects should trigger field's descriptor's __set__()
Reported by: | German M. Bravo | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | 1.4 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | yes | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Setting attributes on deferred objects (DeferredAttribute
) should trigger original field's descriptor's __set__()
(if any).
Currently, specially for custom fields set up as descriptors defining __set__()
, the original field's __set__
is never called when setting object attributes on deferred fields.
Attachments (1)
Change History (6)
by , 12 years ago
Attachment: | #18717-deferred_fields_and_descriptors.diff added |
---|
comment:1 by , 12 years ago
Needs tests: | set |
---|---|
Patch needs improvement: | set |
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 12 years ago
Component: | Uncategorized → Database layer (models, ORM) |
---|---|
Type: | Uncategorized → Bug |
comment:4 by , 9 years ago
Description: | modified (diff) |
---|
comment:5 by , 8 years ago
@Kronuz, is the issue still relevant (I was thinking 7f51876f99851fdc3fef63aecdfbcffa199c26b9 might have helped)? If so, can you update the patch and add a test? Or at least add some more concrete steps to reproduce to help someone else contribute to the issue?
comment:6 by , 8 years ago
Resolution: | → needsinfo |
---|---|
Status: | new → closed |
The patch failes as
DeferredAttribute
no longer hasmodel_ref
. On a side note,_meta.get_field_by_name
can be used instead of iterating.