Opened 7 years ago

Closed 2 years ago

#18717 closed Bug (needsinfo)

Setting attributes on deferred objects should trigger field's descriptor's __set__()

Reported by: German M. Bravo Owned by: nobody
Component: Database layer (models, ORM) Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description (last modified by Tim Graham)

Setting attributes on deferred objects (DeferredAttribute) should trigger original field's descriptor's __set__() (if any).
Currently, specially for custom fields set up as descriptors defining __set__(), the original field's __set__ is never called when setting object attributes on deferred fields.

Attachments (1)

#18717-deferred_fields_and_descriptors.diff (864 bytes) - added by German M. Bravo 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by German M. Bravo

comment:1 Changed 7 years ago by Łukasz Rekucki

Needs tests: set
Patch needs improvement: set
Triage Stage: UnreviewedAccepted

The patch failes as DeferredAttribute no longer has model_ref. On a side note, _meta.get_field_by_name can be used instead of iterating.

Last edited 7 years ago by Łukasz Rekucki (previous) (diff)

comment:2 Changed 6 years ago by Aymeric Augustin

Component: UncategorizedDatabase layer (models, ORM)
Type: UncategorizedBug

comment:4 Changed 4 years ago by Tim Graham

Description: modified (diff)

comment:5 Changed 3 years ago by Tim Graham

@Kronuz, is the issue still relevant (I was thinking 7f51876f99851fdc3fef63aecdfbcffa199c26b9 might have helped)? If so, can you update the patch and add a test? Or at least add some more concrete steps to reproduce to help someone else contribute to the issue?

comment:6 Changed 2 years ago by Claude Paroz

Resolution: needsinfo
Status: newclosed
Note: See TracTickets for help on using tickets.
Back to Top