Opened 20 months ago
Closed 5 months ago
#18659 closed Cleanup/optimization (fixed)
Remove `request.REQUEST`
| Reported by: | aaugustin | Owned by: | bouke |
|---|---|---|---|
| Component: | HTTP handling | Version: | master |
| Severity: | Normal | Keywords: | |
| Cc: | marc.tamlyn@…, eduardocereto@…, bmispelon@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
request.REQUEST provides indifferent access to request.GET or request.POST (PHP style).
This attribute is a legacy from the pre-1.0 days, when you could access the GET or POST data using dict syntax on the request object. request.REQUEST was introduced in 1.0 to make this operation more explicit, with an easy upgrade path.
It's hardly ever a good design pattern to handle GET and POST identically, and it's our responsibility not to provide tools who are more likely to result in bad code than anything else. So I think it's time to deprecate this attribute.
We could deprecate django.utils.datastructures.MergeDict at the same time — it's a 100-lines long class whose sole purpose is to support request.REQUEST.
Attachments (0)
Change History (9)
comment:1 Changed 20 months ago by Alex
- Triage Stage changed from Unreviewed to Accepted
comment:2 Changed 20 months ago by aaugustin
comment:3 Changed 20 months ago by mjtamlyn
- Cc marc.tamlyn@… added
comment:4 Changed 20 months ago by eduardocereto
- Cc eduardocereto@… added
comment:5 Changed 12 months ago by aaugustin
- Component changed from Core (Other) to HTTP handling
comment:6 Changed 12 months ago by bmispelon
- Cc bmispelon@… added
comment:7 Changed 5 months ago by bouke
- Owner changed from nobody to bouke
- Status changed from new to assigned
I've proposed a deprecation in-between PR: https://github.com/django/django/pull/1756
comment:8 Changed 5 months ago by timo
- Has patch set
- Patch needs improvement set
- Version changed from 1.4 to master
Mailing list thread to make sure there is consensus to move forward with this:
https://groups.google.com/d/topic/django-developers/yw7OPb_O0QA/discussion
The patch would also need to be updated to reflect the fact that the deprecation would start in 1.7 (1.6 is feature frozen at this time).
comment:9 Changed 5 months ago by Tim Graham <timograham@…>
- Resolution set to fixed
- Status changed from assigned to closed
This may break a lot of code, so this isn't a decision to make lightly.
Django itself uses request.REQUEST in i18n views, auth, and admin.