|Reported by:||aaugustin||Owned by:||bouke|
|Cc:||marc.tamlyn@…, eduardocereto@…, bmispelon@…||Triage Stage:||Accepted|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||yes|
request.REQUEST provides indifferent access to request.GET or request.POST (PHP style).
This attribute is a legacy from the pre-1.0 days, when you could access the GET or POST data using dict syntax on the request object. request.REQUEST was introduced in 1.0 to make this operation more explicit, with an easy upgrade path.
It's hardly ever a good design pattern to handle GET and POST identically, and it's our responsibility not to provide tools who are more likely to result in bad code than anything else. So I think it's time to deprecate this attribute.
We could deprecate django.utils.datastructures.MergeDict at the same time — it's a 100-lines long class whose sole purpose is to support request.REQUEST.
Change History (11)
comment:7 Changed 17 months ago by bouke
- Owner changed from nobody to bouke
- Status changed from new to assigned
comment:8 Changed 17 months ago by timo
- Has patch set
- Patch needs improvement set
- Version changed from 1.4 to master
comment:9 Changed 17 months ago by Tim Graham <timograham@…>
- Resolution set to fixed
- Status changed from assigned to closed