Opened 13 years ago

Closed 13 years ago

#18645 closed Cleanup/optimization (fixed)

Simplified filesizeformat

Reported by: jerome.renard@… Owned by: nobody
Component: Template system Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Hi,

You will find attached a patch for the filesizeformat template filter.

The patch removes all the multiplications and uses bit shifting instead.

This simplifies the code and (hopefully) makes it easier to read.

Not a major change at all, but just in case.

'Hope that helps :)

Attachments (1)

defaultfilters.diff​ (1.6 KB ) - added by jerome.renard@… 13 years ago.
patch for filesizeformat

Download all attachments as: .zip

Change History (2)

by jerome.renard@…, 13 years ago

Attachment: defaultfilters.diff​ added

patch for filesizeformat

comment:1 by Aymeric Augustin <aymeric.augustin@…>, 13 years ago

Resolution: → fixed
Status: new → closed

In [1e89a208d0d741558c31a161222e8aa96764e08c]:

Fixed #18645 -- Clarified filesizeformat implementation

Thanks Jérôme Renard for the patch.

Note: See TracTickets for help on using tickets.
Back to Top