Inconsistent error handling on admin filter url's

[david@…]

This probably isn't officially supported but there is a curious change to error handling introduced in Django 1.4.

In 1.3 something like

/admin/app/model/?date__gte=moo

would yield e=1 and no 500 error

In 1.4 I get a 500 instead. But only for dates!

?id__gte=moo

yields a e=1

Perhaps this type of hard filtering should just be scorned all together. But I do find it quite useful and a 500 error in such particular situations is odd behavior. I've implemented a hack start and end date filter which is why I've gotten this. Ugly I know.

[Julien Phalip]

I can't seem to reproduce the problem. See the attached patch, where the test passes.

If you can provide a failing test, please do reopen this ticket. Thanks!

[david@…]

It appears linked to having a list_filter on the tested date such as
list_filter = date

In the django regression test you linked, try changing ​admin.py

class ThingAdmin(admin.ModelAdmin):
    list_filter = ('color__warm', 'color__value')

to

class ThingAdmin(admin.ModelAdmin):
    list_filter = ('color__warm', 'color__value', 'date')

then you should get the error.

[Julien Phalip]

I've attached a suggested fix. I'll let someone else review it, and if that's fine then I'll also backport it to 1.4.x to address this small regression.

[Julien Phalip]

I'll try and get that committed soon.

[Julien Phalip <jphalip@…>]

In 336dfc3413b22bc5a5008bba7ff383886da96d60:

[1.4.X] Fixed #18530 -- Fixed a small regression in the admin filters where wrongly formatted dates passed as url parameters caused an unhandled ValidationError. Thanks to david for the report.

[Julien Phalip <jphalip@…>]

In c555741aa7840d8ee4b3a191550924cca6f27105:

Fixed #18530 -- Fixed a small regression in the admin filters where wrongly formatted dates passed as url parameters caused an unhandled ValidationError. Thanks to david for the report.