Opened 12 years ago
Closed 12 years ago
#18522 closed Cleanup/optimization (invalid)
Incosistencies and redundant checks in wizard view
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | contrib.formtools | Version: | 1.4 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Redundant check in the post method:
file:
django/contrib/formtools/wizard/views.py
line 255:
if wizard_goto_step and wizard_goto_step in self.get_form_list():
Note:
See TracTickets
for help on using tickets.
It's just an optimization to avoid calling
self.get_form_list()whenwizard_goto_stepisNone.I don't see how this is a problem.