Opened 4 years ago

Closed 4 years ago

#18522 closed Cleanup/optimization (invalid)

Incosistencies and redundant checks in wizard view

Reported by: fahad@… Owned by: nobody
Component: contrib.formtools Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Redundant check in the post method:


line 255:
if wizard_goto_step and wizard_goto_step in self.get_form_list():

Change History (1)

comment:1 Changed 4 years ago by aaugustin

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to invalid
  • Status changed from new to closed

It's just an optimization to avoid calling self.get_form_list() when wizard_goto_step is None.

I don't see how this is a problem.

Note: See TracTickets for help on using tickets.
Back to Top