Opened 12 years ago
Closed 12 years ago
#18477 closed Bug (fixed)
TabularInline admin uses wrong colspan in Add row
Reported by: | Jiri Suchan | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | 1.4 |
Severity: | Normal | Keywords: | javascript, admin |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | yes |
Description
Problem:
TabularInline admin generates 'Add another' row via javascript, calculating value of colspan
attribute from count of children in first Formset's row. If Formset validation fails, there appears an error message as a first row, which has always only one column. As a result 'Add another' row uses bad value in colspan
(1).
Patch uses last row (instead of first one) for calculating colspan
attribute.
Attachments (2)
Change History (4)
by , 12 years ago
Attachment: | patch_inlines.js added |
---|
by , 12 years ago
Attachment: | inlines_patch.diff added |
---|
calculate proper colspan for 'Add another' row (once again, proper filename ext.)
comment:1 by , 12 years ago
Type: | Uncategorized → Bug |
---|
comment:2 by , 12 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
calculate proper colspan for A