Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18472 closed Cleanup/optimization (fixed)

`set_language` view documentation improvements

Reported by: DrMeers Owned by: DrMeers
Component: Documentation Version: 1.4
Severity: Normal Keywords: i18n, set_language
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

  • I've seen people get confused by including the set_language URL within their i18n_patterns and wondering why it doesn't work (the form POST turns into a redirected GET request which fails); we should probably add a warning to ensure that this URL is locale-independent
  • Why do we have a hardcoded URL as the form action? This should be reversed instead, and possibly have a name added to the URL.

Happy to tackle/commit this, just wanted to make sure I wasn't missing anything.

Change History (4)

comment:1 Changed 3 years ago by jezdez

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 3 years ago by jezdez

Both issues are valid, I'd suggest to open a separate ticket for the hardcoded URL though.

comment:3 Changed 3 years ago by Simon Meers <simon@…>

  • Resolution set to fixed
  • Status changed from new to closed

In [d7816c563b58ed53d49956321d549a16e2b2ebc0]:

Fixed #18472 - Added warning regarding set_language / i18n_patterns.

comment:4 Changed 3 years ago by Simon Meers <simon@…>

In [68fd7f56e18df609561f8c82f247eb0c4cac2f83]:

[1.4.x] Fixed #18472 - Added warning regarding set_language / i18n_patterns.

Backport of d7816c563b58ed53d49956321d549a16e2b2ebc0 from master.

Note: See TracTickets for help on using tickets.
Back to Top