Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18468 closed Uncategorized (duplicate)

Define COMMENT in table / colomns

Reported by: mrechte Owned by: nobody
Component: Database layer (models, ORM) Version: 1.4
Severity: Normal Keywords:
Cc: niwi@… Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Hello,

That would be nice if it was possible to include comment on table / columns at creation time with the syncdb manage.py option.

There could be a new Model Meta option like:

comment = 'This table is for storing blabla"

And a new Field option like:

comment = 'This field is for ...'

Thanks a lot

Change History (5)

comment:1 Changed 3 years ago by niwi

  • Cc niwi@… added
  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Initial implementation for postgresql_psycopg2 backend: https://github.com/niwibe/django/compare/issue_18468

Is only implemented the table comment sql.

If accepted as a new feature, would be nice to make design decisions. Today I put the comment for table in class "Meta", another option is to use the first line of the model docstrings.

For fields, is more simple, just add an optional parameter "comment" at the Field.

Last edited 3 years ago by niwi (previous) (diff)

comment:2 Changed 3 years ago by aaugustin

  • Resolution set to duplicate
  • Status changed from new to closed

This is a duplicate of #13867, which lingered in DDN for two years until I wontfix'd it.

The only argument I've seen is "it'd be nice if...". But I'm against adding features to Django just because we can; there must be a use case.

Could you start a thread on the mailing-list, as recommended in the contributing guide, to see if there is support for this idea?

If there's a good explanation of why you need this, I can reconsider my decision.

comment:3 Changed 3 years ago by niwi

I understand your opinion! In any case, I'll write an email to the list which I think is useful.
Thanks!

comment:4 Changed 3 years ago by mrechte

I assume that most databases have comment on fields / tables feature not just because it is nice. Accessing Django created tables from another tool (for instance pgAdmin) would just make the system more productive. Personally I never create SQL tables without proper comments in the database itself.

comment:5 Changed 3 years ago by lukeplant

The reasons given on #13867 still stand — Django is not aiming to provide a wrapper for every SQL feature. For example, it also doesn't provide an easy way to create stored procedures, functions or views, but you can always execute the SQL manually to add these, or could add some additional Python code that executed the SQL — for example using a South migration — if you want to ensure it always happens.

In addition, if the audience of these comments is people administering the database without reading the Python source code, it doesn't make sense for these comments to be taking up space in the Python code, which has its own way of adding comments (docstrings and comment lines), which are targeted at programmers not DB admins.

Note: See TracTickets for help on using tickets.
Back to Top