Code

#18450 closed Cleanup/optimization (fixed)

Remove default values for i18n JavaScript URLs in Admin templates

Reported by: dhepper Owned by: dhepper
Component: contrib.admin Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Some templates in the admin contain a hard coded default value for the i18n JavaScript URLs:

admin/auth/user/change_password.html:<script type="text/javascript" src="{{ jsi18nurl|default:"../../../../jsi18n/" }}"></script>
admin/change_form.html:<script type="text/javascript" src="{{ jsi18nurl|default:"../../../jsi18n/" }}"></script>
admin/change_list.html: <script type="text/javascript" src="{{ jsi18nurl|default:'../../jsi18n/' }}"></script>

[11:02] apollo13: jezdez: https://github.com/django/django/commit/1e955e0143 you think we can remove the default:"../../" stuff by now? I think no admin site is able to have no jsi18n url by now
[11:04] apollo13: (more or less the only part of the admin still having relative urls at all)
[12:33] jezdez: apollo13: yes

Attachments (0)

Change History (4)

comment:1 Changed 23 months ago by dhepper

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Readable version:

admin/auth/user/change_password.html:<script type="text/javascript" src="{{ jsi18nurl|default:"../../../../jsi18n/" }}"></script>
admin/change_form.html:<script type="text/javascript" src="{{ jsi18nurl|default:"../../../jsi18n/" }}"></script>
admin/change_list.html: <script type="text/javascript" src="{{ jsi18nurl|default:'../../jsi18n/' }}"></script>

[11:02] apollo13: jezdez:  https://github.com/django/django/commit/1e955e0143 you think we can remove the default:"../../" stuff by now? I think no admin site is able to have no jsi18n url by now
[11:04] apollo13: (more or less the only part of the admin still having relative urls at all)
[12:33] jezdez: apollo13: yes

comment:2 Changed 23 months ago by apollo13

  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 22 months ago by julien

There's a pull request here: https://github.com/django/django/pull/139

comment:4 Changed 22 months ago by Florian Apolloner <florian@…>

  • Resolution set to fixed
  • Status changed from new to closed

In [108f8dddeae66efd47c13afa6033f36b6fd39c8f]:

Fixed #18450 -- Removed default values for i18n JavaScript URLs in Admin templates

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.