Opened 13 years ago

Closed 13 years ago

#18447 closed New feature (fixed)

LazyObject doesn't unwrap on dict access

Reported by: FunkyBob Owned by: Zbigniew Siciarz
Component: Utilities Version: dev
Severity: Normal Keywords:
Cc: d1fffuz0r@…, flo@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description


Attachments (3)

lazy.patch​ (666 bytes ) - added by FunkyBob 13 years ago.
18447_tests.patch​ (930 bytes ) - added by Roman Gladkov 13 years ago.
test
lazy_with_tests.patch​ (1.6 KB ) - added by Roman Gladkov 13 years ago.
joined in one

Download all attachments as: .zip

Change History (13)

by FunkyBob, 13 years ago

Attachment: lazy.patch​ added

comment:1 by anonymous, 13 years ago

Makes sense to me, how about a test?

comment:2 by anonymous, 13 years ago

Needs documentation: set
Needs tests: set

comment:3 by Luke Plant, 13 years ago

Needs documentation: unset
Triage Stage: Unreviewed → Accepted

comment:4 by Roman Gladkov, 13 years ago

Cc: d1fffuz0r@… added
Version: 1.4 → master

Added test for the patch in attachment

Last edited 13 years ago by Roman Gladkov (previous) (diff)

by Roman Gladkov, 13 years ago

Attachment: 18447_tests.patch​ added

test

comment:5 by fhahn, 13 years ago

Cc: flo@… added
Needs tests: unset

I think putting the test and the patch into one file would make applying the patch a tiny bit easier.

by Roman Gladkov, 13 years ago

Attachment: lazy_with_tests.patch​ added

joined in one

comment:6 by Roman Gladkov, 13 years ago

tested in Python 2.7, 3.3

comment:7 by Zbigniew Siciarz, 13 years ago

Owner: changed from nobody to Zbigniew Siciarz
Status: new → assigned

comment:8 by Zbigniew Siciarz, 13 years ago

I added more meaningful assertions and renamed the test case to be more consistent with others. Pull request here: ​https://github.com/django/django/pull/829

comment:9 by Aymeric Augustin, 13 years ago

Component: Uncategorized → Utilities

comment:10 by Aymeric Augustin <aymeric.augustin@…>, 13 years ago

Resolution: → fixed
Status: assigned → closed

In 0efafa4c54ab8ad684df66c8e34928bb2ba88656:

Fixed #18447 -- Made LazyObject unwrap on dict access.

Thanks Roman Gladkov and Zbigniew Siciarz.

Note: See TracTickets for help on using tickets.
Back to Top