Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#18403 closed Bug (fixed)

Issue with redefined SimpleCookie with invalid cookie name

Reported by: Stefano Crosta <stefano@…> Owned by: Ivan Kolodyazhny
Component: HTTP handling Version: 1.4
Severity: Normal Keywords: cookie
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Ramiro Morales)

To provoke the error:

from django.http import HttpResponse
response= HttpResponse()

> AttributeError: 'SimpleCookie' object has no attribute 'bad_cookies' 

with a python version that does not accept colons (":") in the cookie name.

Django http/ redefines the SimpleCookie, and initializes bad_cookies in a method load(self, rawdata) that does not seem to be called in this case.

Beside the obvious fact that the cookie name is totally invalid, it looks like bad_cookies is not correctly initialized (I wouldn't mind an error, but a real one!)

Or am I using set_cookie uncorrectly here?

Change History (8)

comment:1 Changed 7 years ago by Ramiro Morales

Description: modified (diff)

comment:2 Changed 7 years ago by Luke Plant

Triage Stage: UnreviewedAccepted

comment:3 Changed 5 years ago by Ivan Kolodyazhny

Owner: changed from nobody to Ivan Kolodyazhny
Status: newassigned

Here is pull request with fix

comment:4 Changed 5 years ago by Tim Graham

Has patch: set
Needs tests: set

This needs a test as well.

comment:5 Changed 5 years ago by Tim Graham

Needs tests: unset

Test was added, but fails on Python 3. Python 3 appears to fail loudly on a bad cookie key rather than storing the key in bad_cookies. Question is whether Django should catch this exception to maintain the same behavior as Python 2 or if we should simply skip the new test on Python 3.

comment:6 Changed 5 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In f2a44528825ac07ca28c8bb7dc01b4375df8dc2c:

Fixed #18403 -- Initialized bad_cookies in SimpleCookie

Thanks Stefano Crosta for the report.

comment:7 Changed 5 years ago by Fabian Topfstedt

I'm having this issue in Django 1.6.1 - is this really fixed !?

response = HttpResponse(json.dumps(result))
response.set_cookie(response, '123', expires=expires)
Internal Server Error: /goodies/ajax/authenticate_goody/
Traceback (most recent call last):
  File "/Users/rothfuchs/Documents/workspace/mygoody/pyenv/lib/python2.7/site-packages/django/core/handlers/", line 114, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/Users/rothfuchs/Documents/workspace/mygoody/goodies/", line 30, in authenticate_goody
    response.set_cookie(response, '123', expires=expires)
  File "/Users/rothfuchs/Documents/workspace/mygoody/pyenv/lib/python2.7/site-packages/django/http/", line 229, in set_cookie
    self.cookies[key] = value
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/", line 592, in __setitem__
    self.__set(key, rval, cval)
  File "/Users/rothfuchs/Documents/workspace/mygoody/pyenv/lib/python2.7/site-packages/django/http/", line 67, in _BaseCookie__set
AttributeError: 'SimpleCookie' object has no attribute 'bad_cookies'

comment:8 Changed 5 years ago by Tim Graham

If you look at the commit above, you'll see it's present on master/1.7a1. It won't be backported to 1.6 as it's not a regression (ticket was open 20 months before it was fixed).

Note: See TracTickets for help on using tickets.
Back to Top