Context Navigation

← Previous Ticket
Next Ticket →

#18347 closed Bug (fixed)

Unit tests contain raw inserts to an identity column

Reported by:	Michael Manfre	Owned by:	Anssi Kääriäinen
Component:	Database layer (models, ORM)	Version:	dev
Severity:	Normal	Keywords:	identity insert, mssql
Cc:		Triage Stage:	Ready for checkin
Has patch:	yes	Needs documentation:	no
Needs tests:	no	Patch needs improvement:	no
Easy pickings:	yes	UI/UX:	no

Description

Two unit tests in transactions_regress.TestTransactionClosing fail for MSSQL because of raw inserts in to an identity column. MSSQL and potentially other 3rd party backends require actions to allow this type of insert.

Change History (10)

comment:1 by Michael Manfre, 12 years ago

Easy pickings:	set
Has patch:	set

Pull request https://github.com/manfre/django/commit/06d8aee7edc1ff2862ad8c64d1097090df46fdfa

Added enable_identity_insert, disable_identity_insert, and
contextmanager identity_insert_enabled to DatabaseOperations for
database backends that need to take special actions to allow
identity inserts.

All raw insert statements that set a value in to the identity field
should include these guards to allow all database backends to
function.

Implementation followed the paradigm used by enable/disable constraints.

comment:2 by Aymeric Augustin, 12 years ago

Triage Stage:	Unreviewed → Accepted

The patch looks pretty good to me.

However, wouldn't it be just as easy to not include the primary key in the inserted values in these two tests? I wouldn't like to expand the database backend API more than necessary.

comment:3 by Anssi Kääriäinen, 12 years ago

An alternate patch which just removes inserts into the primary key field. Would this work for mssql? If not, then adding a new model without autofield primary key is still one possibility.

https://github.com/akaariai/django/tree/ticket_18347