Opened 12 years ago
Closed 12 years ago
#18326 closed Bug (fixed)
servers.LiveServerViews tests fail on windows due to line separator
Reported by: | Michael Manfre | Owned by: | nobody |
---|---|---|---|
Component: | Testing framework | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The tests servers.LiveServerViews.test_static_files and servers.LiveServerViews.test_media_files are explicitly looking for '\n'. The test fails on windows with git autocrlf, which translates the read files to end with '\r\n'.
Attachments (1)
Change History (4)
by , 12 years ago
Attachment: | django-ticket18326.diff added |
---|
comment:1 by , 12 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 12 years ago
Depending on the git crlf setting, it's possible that os.linesep will not match the line separators used in the file, which is why I chose to strip them all.
comment:3 by , 12 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Or use os.linesep?