Opened 4 years ago

Closed 4 years ago

#18318 closed Bug (fixed)

admin_scripts.tests.expected_query_re missing mssql quote characters

Reported by: Michael Manfre Owned by: nobody
Component: Testing framework Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

MSSQL quotes entities with square braces [] and not quotes.

Attachments (1)

django-ticket18318.diff (1.8 KB) - added by Michael Manfre 4 years ago.
Support for the next 3rd party backend

Download all attachments as: .zip

Change History (4)

comment:1 Changed 4 years ago by Anssi Kääriäinen

Needs documentation: unset
Needs tests: unset
Patch needs improvement: set
Triage Stage: UnreviewedAccepted

Lets rewrite the test as something like:
r"create table %s" % connection.ops.quote_name("admin_scripts_article")

That should work for other 3rd party backends, too.

Changed 4 years ago by Michael Manfre

Attachment: django-ticket18318.diff added

Support for the next 3rd party backend

comment:2 Changed 4 years ago by Michael Manfre

Patch needs improvement: unset

Patch updated to use quote_name.

comment:3 Changed 4 years ago by Anssi Kääriäinen <akaariai@…>

Resolution: fixed
Status: newclosed

In [8ee1a664f9ef127bc488b03f478e8ba2f0dc7f19]:

Fixed #18318 -- Changed some tests to be 3rd party DB friendly

Thanks to manfre for report and patch.

Note: See TracTickets for help on using tickets.
Back to Top