Code

Opened 2 years ago

Closed 2 years ago

#18270 closed Bug (fixed)

Erroneous sample email template for password reset

Reported by: schnippi Owned by: nobody
Component: Documentation Version: 1.4
Severity: Normal Keywords: password reset, email template, sample
Cc: Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The sample registration/password_reset_email.html email body template at https://docs.djangoproject.com/en/1.4/topics/auth/#module-django.contrib.auth.views is

Someone asked for password reset for email {{ email }}. Follow the link below:
{{ protocol}}://{{ site_name }}{% url 'auth_password_reset_confirm' uidb36=uid token=token %}

but it should be

Someone asked for password reset for email {{ email }}. Follow the link below:
{{ protocol }}://{{ domain }}{% url 'auth_password_reset_confirm' uidb36=uid token=token %}

Because site_name is a human readable description of the site and not a domain name. So the current example template will get the user to something like "http://My Site/accounts/...", which is not the desired effect.

Attachments (0)

Change History (2)

comment:1 Changed 2 years ago by claudep

  • Easy pickings set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin
  • Type changed from Uncategorized to Bug

Fixed in master (ec5423df05dedeee6651c36dd4d90fec0d8cca7c).

Should be backported to 1.4

comment:2 Changed 2 years ago by claudep

  • Resolution set to fixed
  • Status changed from new to closed

Pushed in stable/1.4.x branch

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.