Opened 4 years ago

Closed 3 years ago

#18263 closed Bug (fixed)

admin/edit_inline/tabular.html only handles hidden fields correctly in the header

Reported by: hvdklauw Owned by: hvdklauw
Component: contrib.admin Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: yes UI/UX: no


So, hidden fields arent suppost to get their own column in the tabular inlines (makes sense)
However the only thing here that get's handled properly is the header part, the actual form column part (the td's) don't add the hidden field to the first column but add their own column.

I'll be adding a patch shortly to correct this problem

Attachments (1)

18263.diff (4.6 KB) - added by hvdklauw 4 years ago.
Added regression test

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by hvdklauw

  • Easy pickings set
  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 4 years ago by jezdez

  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 4 years ago by julien

  • Needs tests set

Thanks for the patch. Could you please add some tests?

Changed 4 years ago by hvdklauw

Added regression test

comment:4 Changed 4 years ago by hvdklauw

  • Needs tests unset
  • Patch needs improvement unset

Damn, wrote those a while ago, just didn't upload them :S

Redid them on the master so they should apply without problems.

comment:5 Changed 3 years ago by Kamu

  • Patch needs improvement set

Tests (and perhaps the code itself) will need updating.

comment:6 Changed 3 years ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 617aceb1b4ec97b4d70f9b3071cb46a645f69f87:

Fixed #18263 -- Corrrected handling of hidden fields in tabular admin inlines.

Thanks hvdklauw for the report and patch.

Note: See TracTickets for help on using tickets.
Back to Top