Opened 12 years ago
Closed 11 years ago
#18263 closed Bug (fixed)
admin/edit_inline/tabular.html only handles hidden fields correctly in the header
Reported by: | Harro | Owned by: | Harro |
---|---|---|---|
Component: | contrib.admin | Version: | 1.4 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | yes | UI/UX: | no |
Description
So, hidden fields arent suppost to get their own column in the tabular inlines (makes sense)
However the only thing here that get's handled properly is the header part, the actual form column part (the td's) don't add the hidden field to the first column but add their own column.
I'll be adding a patch shortly to correct this problem
Attachments (1)
Change History (7)
comment:1 by , 12 years ago
Easy pickings: | set |
---|---|
Has patch: | set |
Status: | new → assigned |
comment:2 by , 12 years ago
Patch needs improvement: | set |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:3 by , 12 years ago
Needs tests: | set |
---|
comment:4 by , 12 years ago
Needs tests: | unset |
---|---|
Patch needs improvement: | unset |
Damn, wrote those a while ago, just didn't upload them :S
Redid them on the master so they should apply without problems.
comment:5 by , 11 years ago
Patch needs improvement: | set |
---|
Tests (and perhaps the code itself) will need updating.
comment:6 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Thanks for the patch. Could you please add some tests?