Code

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#18246 closed Cleanup/optimization (fixed)

Geodjango documentation improvement

Reported by: jose Owned by: nobody
Component: Documentation Version: master
Severity: Normal Keywords: gis
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Hello!

I am just starting with Geodjango, so reading the documentation and learning how to set up a GIS environment in PostgreSQL.

In the 'Geodjango installation' page, in the 'Debian' section, you kindly add a shell script to set up everything in the Post-installation notes. Script is 'create_template_postgis-debian.sh'

In line 41 of the script, the if ((GEOGRAPHY)) is failing and returns the next error:

create_template_postgis-debian.sh: 41: create_template_postgis-debian.sh: GEOGRAPHY: not found

I think it will be a good idea to change this line for a more explicit comparison, in order to prevent this error:

if [ $GEOGRAPHY -eq 1 ]

That works better, and is more exact, I guess.

Hope this little tip to be useful. Thanks for your time!

Attachments (0)

Change History (3)

comment:1 Changed 2 years ago by claudep

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

OK, it seems that the (( syntax is not supported by dash, for example.

comment:2 follow-up: Changed 2 years ago by claudep

  • Keywords gis added
  • Resolution set to fixed
  • Status changed from new to closed

Thanks for the report. Fixed in aaa3382fdc35bfa5e26c029225a2eb190da66b79

comment:3 in reply to: ↑ 2 Changed 2 years ago by jose

Replying to claudep:

Thanks for the report. Fixed in aaa3382fdc35bfa5e26c029225a2eb190da66b79

Thanks to you for taking into account.

Cheers.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.