Opened 13 years ago

Closed 13 years ago

#18241 closed Cleanup/optimization (fixed)

Inline.js should use preventDefault instead of 'return false'

Reported by: marc.neuwirth@… Owned by: nobody
Component: contrib.admin Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Using 'return false' makes it very difficult to add additional event handlers to the add button because it prevent the events from bubbling up; preventDefault appears to be the desired behavior.

​https://github.com/django/django/pull/24

Change History (3)

comment:1 by Claude Paroz, 13 years ago

Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Cleanup/optimization

comment:2 by Adrian Holovaty, 13 years ago

See discussion on the pull request.

comment:3 by Julien Phalip, 13 years ago

Resolution: → fixed
Status: new → closed

This was fixed in 04785d2697b05186362b8d430c06109cdb91c069

Note: See TracTickets for help on using tickets.
Back to Top