Opened 4 years ago

Closed 4 years ago

#18241 closed Cleanup/optimization (fixed)

Inline.js should use preventDefault instead of 'return false'

Reported by: marc.neuwirth@… Owned by: nobody
Component: contrib.admin Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Using 'return false' makes it very difficult to add additional event handlers to the add button because it prevent the events from bubbling up; preventDefault appears to be the desired behavior.

https://github.com/django/django/pull/24

Change History (3)

comment:1 Changed 4 years ago by Claude Paroz

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization

comment:2 Changed 4 years ago by Adrian Holovaty

See discussion on the pull request.

comment:3 Changed 4 years ago by Julien Phalip

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.
Back to Top