#18173 closed Cleanup/optimization (fixed)
Modeladmin documentation for get_changelist suggests its an attribute
| Reported by: | Owned by: | vanessagomes | |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | vanessagomes | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
Based on the admin docs, get_changelist is an attribute, and has been since #16195. However, looking at the source, it's a method and is used as a callable to get the class. I'm proposing it be moved from the options to the methods section instead.
Attachments (1)
Change History (8)
comment:1 by , 13 years ago
| Easy pickings: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
| Type: | Uncategorized → Cleanup/optimization |
comment:2 by , 12 years ago
| Owner: | changed from to |
|---|
by , 12 years ago
| Attachment: | ticket18173-patch.diff added |
|---|
Description of get_changelist was moved to the methods section.
comment:3 by , 12 years ago
| Has patch: | set |
|---|
comment:4 by , 12 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:5 by , 12 years ago
| Cc: | added |
|---|
comment:6 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
It's a good idea to move it to the methods section.
In addition the documentation should be more specific: The get_changelist method gets passed a request object and should return a class inherited from django.contrib.admin.views.main.ChangeList.