Opened 12 years ago
Closed 11 years ago
#18170 closed New feature (wontfix)
[PATCH] Break-out password reset confirmation so that it is re-usable.
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | contrib.auth | Version: | 1.4 |
| Severity: | Normal | Keywords: | |
| Cc: | bmispelon@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Currrently, an app that wishes to override password_reset_confirm has to copy-and-paste the confirmation code into its view. This moves that code into a utils module for re-use.
For an example, please see password_reset_confirm in:
https://github.com/rentalita/django-userena/blob/bootstrap/userena/views.py
Patches for 1.3.1 and 1.4 are attached.
Attachments (2)
Change History (6)
by , 12 years ago
| Attachment: | confirm_password_reset-1.3.1.diff added |
|---|
comment:1 by , 12 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
I don't think django 1.3 or django 1.4 will get this patch. But for 1.5 this seems good. Of course, the function is internal and thus use at your own risk - it can change underneath you, even in a minor release.
See the pull request https://github.com/django/django/pull/12 for a patch against head.
comment:2 by , 11 years ago
| Type: | Uncategorized → New feature |
|---|
comment:4 by , 11 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Given the comments on the PR and the fact that it was closed, I'm going to close this.
Patch against Django 1.3.1.