Code

Opened 2 years ago

Closed 12 months ago

#18170 closed New feature (wontfix)

[PATCH] Break-out password reset confirmation so that it is re-usable.

Reported by: thomas.david.vaughan@… Owned by: nobody
Component: contrib.auth Version: 1.4
Severity: Normal Keywords:
Cc: bmispelon@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Currrently, an app that wishes to override password_reset_confirm has to copy-and-paste the confirmation code into its view. This moves that code into a utils module for re-use.

For an example, please see password_reset_confirm in:

https://github.com/rentalita/django-userena/blob/bootstrap/userena/views.py

Patches for 1.3.1 and 1.4 are attached.

Attachments (2)

confirm_password_reset-1.3.1.diff (2.8 KB) - added by thomas.david.vaughan@… 2 years ago.
Patch against Django 1.3.1.
confirm_password_reset-1.4.diff (2.8 KB) - added by thomas.david.vaughan@… 2 years ago.
Patch against Django 1.4.

Download all attachments as: .zip

Change History (6)

Changed 2 years ago by thomas.david.vaughan@…

Patch against Django 1.3.1.

Changed 2 years ago by thomas.david.vaughan@…

Patch against Django 1.4.

comment:1 Changed 2 years ago by akaariai

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

I don't think django 1.3 or django 1.4 will get this patch. But for 1.5 this seems good. Of course, the function is internal and thus use at your own risk - it can change underneath you, even in a minor release.

See the pull request https://github.com/django/django/pull/12 for a patch against head.

comment:2 Changed 16 months ago by aaugustin

  • Type changed from Uncategorized to New feature

comment:3 Changed 15 months ago by bmispelon

  • Cc bmispelon@… added

Personally, I'd be more favorable to an approach like #17209

comment:4 Changed 12 months ago by timo

  • Resolution set to wontfix
  • Status changed from new to closed

Given the comments on the PR and the fact that it was closed, I'm going to close this.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.