Opened 13 years ago

Closed 11 years ago

#18170 closed New feature (wontfix)

[PATCH] Break-out password reset confirmation so that it is re-usable.

Reported by: thomas.david.vaughan@… Owned by: nobody
Component: contrib.auth Version: 1.4
Severity: Normal Keywords:
Cc: bmispelon@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Currrently, an app that wishes to override password_reset_confirm has to copy-and-paste the confirmation code into its view. This moves that code into a utils module for re-use.

For an example, please see password_reset_confirm in:

https://github.com/rentalita/django-userena/blob/bootstrap/userena/views.py

Patches for 1.3.1 and 1.4 are attached.

Attachments (2)

confirm_password_reset-1.3.1.diff (2.8 KB ) - added by thomas.david.vaughan@… 13 years ago.
Patch against Django 1.3.1.
confirm_password_reset-1.4.diff (2.8 KB ) - added by thomas.david.vaughan@… 13 years ago.
Patch against Django 1.4.

Download all attachments as: .zip

Change History (6)

by thomas.david.vaughan@…, 13 years ago

Patch against Django 1.3.1.

by thomas.david.vaughan@…, 13 years ago

Patch against Django 1.4.

comment:1 by Anssi Kääriäinen, 13 years ago

Triage Stage: UnreviewedAccepted

I don't think django 1.3 or django 1.4 will get this patch. But for 1.5 this seems good. Of course, the function is internal and thus use at your own risk - it can change underneath you, even in a minor release.

See the pull request https://github.com/django/django/pull/12 for a patch against head.

comment:2 by Aymeric Augustin, 12 years ago

Type: UncategorizedNew feature

comment:3 by Baptiste Mispelon, 12 years ago

Cc: bmispelon@… added

Personally, I'd be more favorable to an approach like #17209

comment:4 by Tim Graham, 11 years ago

Resolution: wontfix
Status: newclosed

Given the comments on the PR and the fact that it was closed, I'm going to close this.

Note: See TracTickets for help on using tickets.
Back to Top