Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#1816 closed defect (fixed)

[patch] magic-removal using deprecated attribute in db/models/manipulators.py line 218

Reported by: coconutstudio@… Owned by: adrian
Component: contrib.admin Version: magic-removal
Severity: major Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In admin page, error occurs as:
AttributeError at /admin/apt/apt_property/2/
'Apt_Unit' object has no attribute 'set_feature'
Request Method: POST
Request URL: http://localhost:8000/admin/apt/apt_property/2/
Exception Type: AttributeError
Exception Value: 'Apt_Unit' object has no attribute 'set_feature'
Exception Location: C:\Program Files\Python24\lib\site-packages\django\db\models\manipulators.py in save, line 218

Attachments (1)

manipulators.py.diff (1.2 KB) - added by coconutstudio@… 9 years ago.
manipulators.py.diff

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by coconutstudio@…

  • Owner changed from adrian to anonymous
  • Status changed from new to assigned

in admin, error occurs when following through inlined models with many-to-many relationship. This part of the code was not converted for magic-removal. I've written a fix and I'm submitting a patch ... but it is very shaky as this is my first attempt at anything in Djano (let alone in Python), so please take a look and merge/fix/etc. Thanks.

Changed 9 years ago by coconutstudio@…

manipulators.py.diff

comment:2 Changed 9 years ago by anonymous

  • Summary changed from magic-removal using deprecated attribute in db/models/manipulators.py line 218 to [patch] magic-removal using deprecated attribute in db/models/manipulators.py line 218

comment:3 Changed 9 years ago by anonymous

  • Owner changed from anonymous to adrian
  • Status changed from assigned to new

comment:4 Changed 9 years ago by umbrae@…

Appears that patch stops the error, but doesn't actually restore functionality. When I submit from the admin interface, it works for one user, but not for any other users after that.

comment:5 Changed 9 years ago by anonymous

  • priority changed from normal to high
  • Severity changed from normal to major

comment:6 Changed 9 years ago by Gary Wilson <gary.wilson@…>

  • milestone changed from Version 0.92 to Version 1.0

0.92 is long gone.

comment:7 Changed 9 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [3830]) Fixes #1816, #2243 -- Removed a stale remnant of pre-magic removal code in manipulators that modify m2m object that are edited inline. Thanks to dolemite@… and coconutstudio@… for the original reports, Tyson Tate for a clean test case, and Jay Parlar for helping out with a solution.

comment:8 Changed 9 years ago by anonymous

  • milestone Version 1.0 deleted

Milestone Version 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top