Opened 19 years ago

Closed 18 years ago

Last modified 18 years ago

#1816 closed defect (fixed)

[patch] magic-removal using deprecated attribute in db/models/manipulators.py line 218

Reported by: coconutstudio@… Owned by: Adrian Holovaty
Component: contrib.admin Version: magic-removal
Severity: major Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In admin page, error occurs as:
AttributeError at /admin/apt/apt_property/2/
'Apt_Unit' object has no attribute 'set_feature'
Request Method: POST
Request URL: ​http://localhost:8000/admin/apt/apt_property/2/
Exception Type: AttributeError
Exception Value: 'Apt_Unit' object has no attribute 'set_feature'
Exception Location: C:\Program Files\Python24\lib\site-packages\django\db\models\manipulators.py in save, line 218

Attachments (1)

manipulators.py.diff​ (1.2 KB ) - added by coconutstudio@… 19 years ago.
manipulators.py.diff

Download all attachments as: .zip

Change History (9)

comment:1 by coconutstudio@…, 19 years ago

Owner: changed from Adrian Holovaty to anonymous
Status: new → assigned

in admin, error occurs when following through inlined models with many-to-many relationship. This part of the code was not converted for magic-removal. I've written a fix and I'm submitting a patch ... but it is very shaky as this is my first attempt at anything in Djano (let alone in Python), so please take a look and merge/fix/etc. Thanks.

by coconutstudio@…, 19 years ago

Attachment: manipulators.py.diff​ added

manipulators.py.diff

comment:2 by anonymous, 19 years ago

Summary: magic-removal using deprecated attribute in db/models/manipulators.py line 218 → [patch] magic-removal using deprecated attribute in db/models/manipulators.py line 218

comment:3 by anonymous, 18 years ago

Owner: changed from anonymous to Adrian Holovaty
Status: assigned → new

comment:4 by umbrae@…, 18 years ago

Appears that patch stops the error, but doesn't actually restore functionality. When I submit from the admin interface, it works for one user, but not for any other users after that.

comment:5 by anonymous, 18 years ago

priority: normal → high
Severity: normal → major

comment:6 by Gary Wilson <gary.wilson@…>, 18 years ago

milestone: Version 0.92 → Version 1.0

0.92 is long gone.

comment:7 by Russell Keith-Magee, 18 years ago

Resolution: → fixed
Status: new → closed

(In [3830]) Fixes #1816, #2243 -- Removed a stale remnant of pre-magic removal code in manipulators that modify m2m object that are edited inline. Thanks to dolemite@… and coconutstudio@… for the original reports, Tyson Tate for a clean test case, and Jay Parlar for helping out with a solution.

comment:8 by (none), 18 years ago

milestone: Version 1.0

Milestone Version 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top