Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#18156 closed Bug (fixed)

Wrong signature for ModelAdmin.change_view in documentation

Reported by: arthurprat@… Owned by: nobody
Component: Documentation Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

In the documentation (/ref/contrib/admin/), ModelAdmin's method change_view is documented as:
change_view(self, request, object_id, extra_context=None)

while it actually is (since 1.4 I guess):
change_view(self, request, object_id, form_url="" , extra_context=None)

which can lead to hard-to-understand bugs.

Change History (3)

comment:1 Changed 4 years ago by claudep

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 4 years ago by claudep

  • Resolution set to fixed
  • Status changed from new to closed

In [17918]:

Fixed #18156 -- Updated signature of ModelAdmin change_view in docs to reflect r17466. Thanks arthurprat for the report.

comment:3 Changed 4 years ago by claudep

In [17919]:

[1.4.X] Fixed #18156 -- Updated signature of ModelAdmin change_view in docs to reflect r17466. Thanks arthurprat for the report.

Backport of r17918 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top