Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#18122 closed Cleanup/optimization (fixed)

Title is unclear at https://docs.djangoproject.com/en/1.4/topics/auth/#limiting-access-to-generic-views

Reported by: nick@… Owned by: nobody
Component: Documentation Version: 1.4
Severity: Normal Keywords: wording, heading, permissions, auth
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

"Limiting access to generic views" could be interpreted as "Limit the user's access such that he can only access generic views". What is meant is "Apply authentication tests to generic views".

The earlier headings "Limiting access to logged-in users", and "Limiting access to logged-in users that pass a test" use a different sense of "limiting access to", and the subtle change of meaning could be confusing:

(Limiting access to) (logged-in users),

and

(Limiting access to) (generic views)

vs

(Limiting) (access to generic views)

Some suggested alternative headings:

  • Limiting access when using generic views
  • Limiting access for generic views
  • Limiting access with generic views
  • Applying authentication tests to generic views

Change History (3)

comment:1 Changed 5 years ago by Jannis Leidel

Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization

comment:2 Changed 4 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In [964979e8ecec3ceccb2119ccb7270111b953611e]:

Fixed #18122 - Clarified section title regarding applying permissions to generic views.

comment:3 Changed 4 years ago by Tim Graham <timograham@…>

In [751a34e4b345c303c131bf72918073ec853a66aa]:

[1.4.x] Fixed #18122 - Clarified section title regarding applying permissions to generic views.

Backport of 964979e8ecec3ceccb2119ccb7270111b953611e from master.

Note: See TracTickets for help on using tickets.
Back to Top