order_with_respect_to should construct set_RELATED_order() method name from related_name

[Daniel Swarbrick]

If two identically named models in separate apps refer to a parent to the same parent model in their order_with_respect_to, only one set_RELATED_order() method is created on the parent model.

[Daniel Swarbrick]

This following situation would cause this problem to surface:

    class Device(models.Model):
        name = CharField(max_length=60, unique=True)
        ...
     
     
    # foo/models.py
    class ExpansionModule(models.Model):
        device = models.ForeignKey(Device, related_name='foo_expansionmodule_set')
        module_type = models.CharField(max_length=32, choices=EXPANSION_MODULE_CHOICES)
        ... # additional fields specific to foo
     
        class Meta:
            order_with_respect_to = 'device'
     
     
    # bar/models.py
    class ExpansionModule(models.Model):
        device = models.ForeignKey(Device, related_name='bar_expansionmodule_set')
        module_type = models.CharField(max_length=32, choices=EXPANSION_MODULE_CHOICES)
        ... # additional fields specific to bar
     
        class Meta:
            order_with_respect_to = 'device'

"Device" objects would only have the one set_expansionmodule_order() method.

[Aymeric Augustin]

The problem is valid. However the proposed solution doesn't guarantee backwards compatibility. I'm not sure of what we should do.

[anonymous]

How about making the order_with_respect_to attribute either a model name string for backwards compatibility, or a two-tuple, containing the parent model, and a name to assign the relationship? It's perhaps not the most elegant, but would satisfy both requirements.

[Aymeric Augustin]

We're getting rid of the DDN state, and this is a valid problem.