Opened 3 years ago

Closed 3 years ago

#18035 closed Cleanup/optimization (fixed)

Remove AdminMediaHandler

Reported by: aaugustin Owned by: nobody
Component: contrib.admin Version: master
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As explained in the deprecation timeline.

Attachments (2)

18035-1.diff (22.4 KB) - added by claudep 3 years ago.
AdminMediaHandler removal
18035-2.diff (24.7 KB) - added by claudep 3 years ago.
Fixed BaseRunserverCommand issue

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by claudep

AdminMediaHandler removal

comment:1 Changed 3 years ago by claudep

  • Has patch set

My patch goes a bit further and also rename some variable names containing 'media' to 'static'.

comment:2 Changed 3 years ago by jezdez

  • Patch needs improvement set

You remove the Command class from the runserver management command module, that means it'll be broken when not using staticfiles

Changed 3 years ago by claudep

Fixed BaseRunserverCommand issue

comment:3 Changed 3 years ago by claudep

  • Patch needs improvement unset

comment:4 Changed 3 years ago by ramiro

  • Triage Stage changed from Accepted to Ready for checkin

comment:5 Changed 3 years ago by claudep

  • Resolution set to fixed
  • Status changed from new to closed

In [17879]:

Fixed #18035 -- Removed deprecated AdminMediaHandler, as per official deprecation timeline. Thanks Jannis Leidel and Ramiro Morales for the review.

Note: See TracTickets for help on using tickets.
Back to Top