Opened 12 years ago

Closed 12 years ago

#18035 closed Cleanup/optimization (fixed)

Remove AdminMediaHandler

Reported by: Aymeric Augustin Owned by: nobody
Component: contrib.admin Version: dev
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As explained in the ​deprecation timeline.

Attachments (2)

18035-1.diff​ (22.4 KB ) - added by Claude Paroz 12 years ago.
AdminMediaHandler removal
18035-2.diff​ (24.7 KB ) - added by Claude Paroz 12 years ago.
Fixed BaseRunserverCommand issue

Download all attachments as: .zip

Change History (7)

by Claude Paroz, 12 years ago

Attachment: 18035-1.diff​ added

AdminMediaHandler removal

comment:1 by Claude Paroz, 12 years ago

Has patch: set

My patch goes a bit further and also rename some variable names containing 'media' to 'static'.

comment:2 by Jannis Leidel, 12 years ago

Patch needs improvement: set

You remove the Command class from the runserver management command module, that means it'll be broken when not using staticfiles

by Claude Paroz, 12 years ago

Attachment: 18035-2.diff​ added

Fixed BaseRunserverCommand issue

comment:3 by Claude Paroz, 12 years ago

Patch needs improvement: unset

comment:4 by Ramiro Morales, 12 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Claude Paroz, 12 years ago

Resolution: → fixed
Status: new → closed

In [17879]:

Fixed #18035 -- Removed deprecated AdminMediaHandler, as per official deprecation timeline. Thanks Jannis Leidel and Ramiro Morales for the review.

Note: See TracTickets for help on using tickets.
Back to Top