Opened 12 years ago

Closed 12 years ago

#18033 closed Cleanup/optimization (fixed)

Remove the function-based generic view modules

Reported by: Aymeric Augustin Owned by: nobody
Component: Generic views Version: dev
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As explained in the deprecation timeline.

Attachments (3)

18033-wip.diff (142.4 KB ) - added by Claude Paroz 12 years ago.
Remove function-based generic views - WIP
18033-2.diff (149.8 KB ) - added by Claude Paroz 12 years ago.
Patch including docs
18033-3.diff (152.9 KB ) - added by Claude Paroz 12 years ago.
Updated to current trunk

Download all attachments as: .zip

Change History (8)

by Claude Paroz, 12 years ago

Attachment: 18033-wip.diff added

Remove function-based generic views - WIP

comment:1 by Claude Paroz, 12 years ago

Has patch: set
Needs documentation: set
Patch needs improvement: set

I think for code and tests, the patch is in good shape (tests pass with SQLite). However there are still mentions of generic views in the documentation. It's not always trivial to update. I will not have time to work on this for the next day at least, so feel free to take the burden :-)

by Claude Paroz, 12 years ago

Attachment: 18033-2.diff added

Patch including docs

comment:2 by Claude Paroz, 12 years ago

Patch needs improvement: unset

I think I have now removed all references to function-based reference views.

by Claude Paroz, 12 years ago

Attachment: 18033-3.diff added

Updated to current trunk

comment:3 by Anssi Kääriäinen, 12 years ago

My short review of this:

  • Tests passed on SQLite.
  • I could not find any code references or doc references to the function based generic views.
  • The docs can be built.

One warning when building the docs: /home/akaariai/Programming/django/docs/releases/1.3-alpha-1.txt:41: WARNING: Mismatch: both interpreted text role prefix and reference suffix.

A question: there are a lot of .po files referencing the create_update.py - I guess these will be cleared later on?

Apart of the docs warning the patch looks good to me.

in reply to:  3 comment:4 by Claude Paroz, 12 years ago

Thanks a lot for the review. I will fix the warning before the commit.

Replying to akaariai:

A question: there are a lot of .po files referencing the create_update.py - I guess these will be cleared later on?

Yes, when the pot files will be rebuilt, this will automatically disappear.

comment:5 by Claude Paroz, 12 years ago

Resolution: fixed
Status: newclosed

In [17937]:

Fixed #18033 -- Removed function-based generic views, as per official deprecation timeline. Rest in peace! Thanks Anssi Kääriäinen for the review.

Note: See TracTickets for help on using tickets.
Back to Top