Opened 6 years ago

Closed 5 years ago

#17984 closed Bug (wontfix)

admin list_filter security fix doesn't allow 'pk' lookups in query string

Reported by: 3point2 Owned by: nobody
Component: contrib.admin Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Let's say I have a Payment model containing a received_by field that is a ForeignKey to a Customer model.

Now I add this to my Payment ModelAdmin:

list_filter = ["received_by"]

If I use a query string like "?received_by__id__exact=2" on the payment changelist view, there is no problem. This is the form that the admin itself uses for the filter. Using something more implicit like "?received_by__id=2" works fine too.

However, using "?received_by__pk=2" raises SuspiciousOperation. This was introduced by the security fix in r15031.

The lookup_allowed method in admin/ explicitly makes an exception for "__id" (or whatever the primary key attribute of the model is explicitly called), but it doesn't allow direct use of the 'pk' shortcut.

The point of the security fix was to only allow lookups specified by list_filter. However, in its current form it also causes the query string syntax to diverge from the documented lookup syntax . I suggest allowing use of the pk shortcut in the query string.

I would be happy to write a patch for this if the developers agree it should be fixed.

Change History (3)

comment:1 Changed 6 years ago by 3point2

Component: Uncategorizedcontrib.admin

comment:2 Changed 6 years ago by Adrien Lemaire

Triage Stage: UnreviewedDesign decision needed

comment:3 Changed 5 years ago by Aymeric Augustin

Resolution: wontfix
Status: newclosed

The querystring in the admin URLs isn't a public API, and it isn't meant to provide access to the model lookup API -- it just happens to similar.

You can override lookup_allowed if you need to. See also #17985.

Note: See TracTickets for help on using tickets.
Back to Top