Code

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#17982 closed Uncategorized (wontfix)

please unbundle jquery

Reported by: mrunge@… Owned by: nobody
Component: contrib.admin Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There's jquery 1.4.2 included for admin-interface. Current jquery is version 1.7.2. I guess, most django sites already have jquery in modern versions included, there's no need for django to bundle this.

From a system integration point of view: I'd like to update/patch jquery by updating one package and don't want to know, framework a includes jquery, framework ... uses it, too. As a conclusion, this is a nice feature, one wants to have.

Attachments (0)

Change History (5)

comment:1 Changed 2 years ago by jezdez

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to wontfix
  • Status changed from new to closed

jQuery is used internally in the admin only and is properly namespaced as django.jQuery. Django relies on it as a library for some of the admin widgets, so unbundling would make using the Django admin much harder than it should be.

comment:2 follow-up: Changed 2 years ago by Kudlaty

maybe we should create something like stand alone package django-jquery,
wich will be pre-installed.

so, with that we will get possibility to upgrade jquery package, and not django :)
but, ofc django-jquery package should be on djangoproject repository
and cos of that, we need to add command to check for upgrade and upgrade package

For futher, this system can be used to split django into small packages like jquery, orm, auth, and more :)

comment:3 in reply to: ↑ 2 Changed 2 years ago by mrunge@…

Replying to Kudlaty:

maybe we should create something like stand alone package django-jquery,
wich will be pre-installed.

so, with that we will get possibility to upgrade jquery package, and not django :)
but, ofc django-jquery package should be on djangoproject repository
and cos of that, we need to add command to check for upgrade and upgrade package

For futher, this system can be used to split django into small packages like jquery, orm, auth, and more :)

something like this was my intention. Another point: when there is a security flaw, you just have to update one package, not a bunch of packages.

comment:4 Changed 2 years ago by Kudlaty

with that system, i think we need to add some django core settings or smth' like that, to mark django-jquery package as required...

problems also can occur when we upgrade jquery package, and admin panel will get bugged cos new jquery remove or changed some function that we use in admin panel...

comment:5 Changed 2 years ago by aaugustin

Not having external dependencies is a design choice of Django.

This has been discussed in the utmost detail in the past. Like jezdez said, the decision is to keep jQuery bundled in the admin, and namespace it.

I'm sorry, but this isn't going to change.

Last edited 2 years ago by aaugustin (previous) (diff)

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.